Commit Graph

24 Commits

Author SHA1 Message Date
kyslov
4ba3098ecb Fix static analysis warnings
With switching to clang-7.0.1 we got new warnings. With this change the
warnings are back to 0 for all configurations (excluding warnings in
third_party)

BUG=webm:1616

Change-Id: I25ceb592c425394e8f14d333fb5680144f892213
2019-04-11 17:37:15 -07:00
sdeng
287d1d64ea tiny_ssim: Fix an 'Uninitialized argument value' bug
found by clang-7.0.1 static analysis.
BUG=webm:1616

Change-Id: I2f7d1376e82e35227ad96d34417014ce5680ad96
2019-04-06 02:55:06 +00:00
sdeng
39ce1c0ab1 tiny_ssim: Fix an 'Uninitialized argument value' bug
found by clang-7.0.1 static analysis.
BUG=webm:1616

Change-Id: I7fb318aa7d4c8dd0a96bb20c6f8706ca1a632696
2019-04-05 21:51:41 +00:00
Johann
850e014a8e tiny_ssim.c: resolve missing declarations
-Wmissing-declarations exposed several unused functions.

BUG=webm:1584

Change-Id: I88dfeb8ffa31253a0fb7674f6fe5fcd496179f96
2018-12-20 17:10:44 +00:00
sdeng
d931eb556b No need to shift in SSIM calculations
We only need to shift in the encoder when the input bit depth
does not equal to the encoder internal bit depth.

Change-Id: If9af62382ac6824f33dc7dcdd3d3ff7802b92e9a
2018-12-18 16:46:29 -08:00
sdeng
9d8122dd72 Disallow the comparison between videos with different bit depth
Change-Id: I1fd8e991f2440925e989d8e7ab33fdf5f6b1d36b
2018-12-17 15:25:37 -08:00
sdeng
de38e2c36f Remove unused code in tiny_ssim
Change-Id: Ife6eb3f8651daa209eeeb8eff85158f00d418647
2018-12-14 08:47:46 -08:00
sdeng
6dc612758c Fix overflow in calculating highbd SSIM
Example internal stats
Before the fix:
Bitrate	AVGPsnr	GLBPsnr	AVPsnrP	GLPsnrP	VPXSSIM	VPSSIMP	FASTSIM	PSNRHVS	WstPsnr	WstSsim	WstFast	WstHVS	AVPsnrY	APsnrCb	APsnrCr	  Block	WstBlck	Consist	WstCons	    Time	RcErr	AbsErr
 153.39	 37.131	 36.420	 37.151	 36.437	716.077	817.445	 10.422	 34.347	 32.980	  0.916	  9.281	 30.208	 36.024	 41.830	 40.581	  0.000	  0.000	100.000	100.000	   55006	   2.26	   2.26
No mismatch detected in recon buffers

After the fix:
Bitrate	AVGPsnr	GLBPsnr	AVPsnrP	GLPsnrP	VPXSSIM	VPSSIMP	FASTSIM	PSNRHVS	WstPsnr	WstSsim	WstFast	WstHVS	AVPsnrY	APsnrCb	APsnrCr	  Block	WstBlck	Consist	WstCons	    Time	RcErr	AbsErr
 153.39	 37.131	 36.420	 37.151	 36.437	 69.808	 70.023	 10.422	 34.347	 32.980	  0.910	  9.281	 30.208	 36.024	 41.830	 40.581	  0.000	  0.000	100.000	100.000	   55067	   2.26	   2.26
No mismatch detected in recon buffers

Change-Id: I820abc498c1543548f193874046582b50afd0238
2018-12-05 00:55:41 +00:00
Angie Chiang
6234256646 Fix scan_build warnings in tiny_ssim.c
BUG=webm:1575

Change-Id: I022794054b494512903d912bdbf3e85461f31665
2018-11-21 11:24:09 -08:00
Angie Chiang
0310ebd8d1 Fix scan_build warnings in tiny_ssim.c
BUG=webm:1575

Change-Id: I3ad3af49d778f102e9152dcb1eb9d5c048756cdf
2018-11-19 18:45:23 -08:00
Jingning Han
794b033f78 Minor clean-up in tiny_ssim.c
Report the correct filename in error message.
Explicitly assign floating point value to double type.

Change-Id: I42fd2da6e16b1e3e7ec221d5d562a728a93c0196
2018-10-02 10:22:56 -07:00
Liu Peng
cb671194c9 fix a bug of tiny_ssim to handle odd frame sizes
Change-Id: Id8ef0eb211517a8f8ec764ec398d16efb9320540
2018-09-14 21:51:40 +00:00
Liu Peng
e196a6ae71 fix a bug of tiny_ssim when the bit depth is 8
Change-Id: I2563e661c71b474fe04b70cd9b713d478a27ac5f
2018-09-14 20:10:15 +00:00
Jim Bankoski
eb012d74f8 tiny_ssim: fix for odd image sizes.
Change-Id: I7dd1e37c5de3efccc07fcdc877653d4873a88266
2018-05-30 19:00:36 +00:00
Scott LaVarnway
8d471fcee2 tiny_ssim.c : clang compile error fix
Change-Id: Ic10ba580fd5da7d6ff7fa0f33db72fb0c1a97801
2017-11-14 04:38:00 -08:00
Jim Bankoski
becab42eee add 10 and 12 bit to tiny_ssim
Change-Id: I92e4dba2d1682a0d77ad9a214ec4312b1cf4d42e
2017-11-13 10:56:42 -08:00
James Zern
31d6ba9a54 tiny_ssim: make some functions static
quiets -Wmissing-prototypes

Change-Id: If2e77c921b2fba456ed8d94119773e360d90b878
2017-06-16 15:36:32 -07:00
Jim Bankoski
393d9d0195 tiny_ssim.c : adds y4m support to tiny_ssim.
Change-Id: I7a13b7e3a1e11ddbe4be3009edf03528e1bc7647
2017-03-07 08:37:00 -08:00
Johann
c7342f35c8 tiny_ssim: clean up on failure
Clears up clang static analysis warnings about memory leaks.

Change-Id: I60d4d0f3794735a8b81d9da4a30d19e7a9cba9cf
2017-02-17 03:28:34 +00:00
Peter Boström
a9ae351667 Add per-frame SSIM/PSNR stats to tools/tiny_ssim.
Adds an optional output framestats.csv file that prints comparions
per-frame instead of averaged over the entire clip. It prints
per-channel and combined metrics for SSIM and PSNR.

Change-Id: Id28dfade27bc5775b59a9d83cfe8b37d1d52b686
2017-01-17 10:47:50 -05:00
Peter Boström
605ca82e7f Add Y,U,V channel metrics and unweighted metrics.
Renames SSIM to VpxSSIM as an upscaled weighted SSIM metric, then prints
Y, U and V channels unweighted as well as a weighted but not scaled SSIM
score that's 8/1/1 parts Y/U/V (same as VpxSSIM).

Change-Id: Iff800cc8f145314eeb1a9b4af1e11a25bec095ca
2017-01-11 14:51:18 -05:00
James Zern
086aab7e13 tiny_ssim: fix visual studio build
s/inttypes.h/vpx_integer.h/
clear a uint64_t -> double conversion warning

Change-Id: I58d108b083787a754152eb79ef6df61c2c5f95b1
2016-10-29 13:04:07 -07:00
Peter Boström
fd4efde489 Add temporal-layer support to tiny_ssim.
Permits skipping 0, 1/2 or 3/4 of the frames, corresponding to
temporal layers 2, 1 and 0 of a 3-temporal-layer encoding. 1/2
corresponds to TL0 in a 2-layer encoding.

Change-Id: I7f6d131f63707e5262fc67d111bfb3a751ede90d
2016-10-28 14:56:05 -04:00
Peter Boström
7c75cae74a Add tools/tiny_ssim for generating SSIM/PSNR.
Change-Id: Icc3e5aaa6636ffe17dc9da5f7a80afaccbde509a
2016-10-28 12:39:49 -04:00