LineageOS/android_external_nano
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

backups: take an unlikely condition into account

Browse Source 
Between the first stat (that sets 'realexists') and the second stat
(directly after), the file might have disappeared, which would mean
that current_stat would be NULL.  Prevent dereferencing this further
down.
This commit is contained in:
Benno Schulenberg
2016-05-21 13:50:14 +02:00
parent 8bf5e58f37
commit f9fe9a7d57
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/files.c
View File

@@ -1801,9 +1801,9 @@ bool write_file(const char *name, FILE *f_open, bool tmp, append_type
* aren't appending, prepending, or writing a selection, we backup * aren't appending, prepending, or writing a selection, we backup
* only if the file has not been modified by someone else since nano * only if the file has not been modified by someone else since nano
* opened it. */ * opened it. */
if (ISSET(BACKUP_FILE) && !tmp && realexists && ((append != OVERWRITE || if (ISSET(BACKUP_FILE) && !tmp && realexists && openfile->current_stat &&
openfile->mark_set) || (openfile->current_stat && (append != OVERWRITE || openfile->mark_set ||
openfile->current_stat->st_mtime == st.st_mtime))) { openfile->current_stat->st_mtime == st.st_mtime)) {
int backup_fd; int backup_fd;
FILE *backup_file; FILE *backup_file;
char *backupname; char *backupname;