LineageOS/android_hardware_libhardware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify usage of smart pointers

Browse Source 
- Members should be smart (shared or unique)
- Prefer function args to be bare, unless the arg is intended to be
  stored by the callee
- Function args that are smart should be const refs to avoid an extra
  copy

Change-Id: I8052fa432bcffbabff9d67a8d568640cac64d4ad
This commit is contained in:
Tim Kilbourn
2015-04-29 13:50:17 -07:00
parent eedee7b8b5
commit c929d25095
8 changed files with 45 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/input/evdev/InputDeviceManager.cpp
View File

@@ -24,7 +24,7 @@
namespace android {
void InputDeviceManager::onInputEvent(std::shared_ptr<InputDeviceNode> node, InputEvent& event,
void InputDeviceManager::onInputEvent(const std::shared_ptr<InputDeviceNode>& node, InputEvent& event,
nsecs_t event_time) {
if (mDevices[node] == nullptr) {
ALOGE("got input event for unknown node %s", node->getPath().c_str());
@@ -33,11 +33,11 @@ void InputDeviceManager::onInputEvent(std::shared_ptr<InputDeviceNode> node, Inp
mDevices[node]->processInput(event, event_time);
}
void InputDeviceManager::onDeviceAdded(std::shared_ptr<InputDeviceNode> node) {
void InputDeviceManager::onDeviceAdded(const std::shared_ptr<InputDeviceNode>& node) {
mDevices[node] = std::make_shared<EvdevDevice>(node);
}
void InputDeviceManager::onDeviceRemoved(std::shared_ptr<InputDeviceNode> node) {
void InputDeviceManager::onDeviceRemoved(const std::shared_ptr<InputDeviceNode>& node) {
if (mDevices[node] == nullptr) {
ALOGE("could not remove unknown node %s", node->getPath().c_str());
return;