LineageOS/android_hardware_libhardware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Document reentrancy and error conditions

Browse Source 
The hotplug callback is non-reentrant. The display config functions
return an error if called for a disconnected display type.

Change-Id: I52d11a53f9b30a7c39e98b0a9b07eb97a3d2becd
This commit is contained in:
Jesse Hall
2012-09-19 22:53:30 -07:00
parent 4fbd199696
commit d91697ab8f
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/hardware/hwcomposer.h
View File

@@ -326,6 +326,9 @@ typedef struct hwc_procs {
* other threads may be calling into the h/w composer while the callback * other threads may be calling into the h/w composer while the callback
* is in progress. * is in progress.
* *
* The h/w composer must serialize calls to the hotplug callback; only
* one thread may call it at a time.
*
* This callback will be NULL if the h/w composer is using * This callback will be NULL if the h/w composer is using
* HWC_DEVICE_API_VERSION_1_0. * HWC_DEVICE_API_VERSION_1_0.
*/ */
@@ -485,7 +488,8 @@ typedef struct hwc_composer_device_1 {
* implementation should choose one and report it as the first config in * implementation should choose one and report it as the first config in
* the list. Reporting the not-chosen configs is not required. * the list. Reporting the not-chosen configs is not required.
* *
* Returns 0 on success or -errno on error. * Returns 0 on success or -errno on error. If disp is a hotpluggable
* display type and no display is connected, an error should be returned.
* *
* This field is REQUIRED for HWC_DEVICE_API_VERSION_1_1 and later. * This field is REQUIRED for HWC_DEVICE_API_VERSION_1_1 and later.
* It should be NULL for previous versions. * It should be NULL for previous versions.
@@ -506,8 +510,12 @@ typedef struct hwc_composer_device_1 {
* *
* This field is REQUIRED for HWC_DEVICE_API_VERSION_1_1 and later. * This field is REQUIRED for HWC_DEVICE_API_VERSION_1_1 and later.
* It should be NULL for previous versions. * It should be NULL for previous versions.
*
* If disp is a hotpluggable display type and no display is connected,
* or if config is not a valid configuration for the display, a negative
* value should be returned.
*/ */
void (*getDisplayAttributes)(struct hwc_composer_device_1* dev, int disp, int (*getDisplayAttributes)(struct hwc_composer_device_1* dev, int disp,
uint32_t config, const uint32_t* attributes, int32_t* values); uint32_t config, const uint32_t* attributes, int32_t* values);
/* /*