From dde2a9d4b5129fa836d211a75f0040bf552c94c9 Mon Sep 17 00:00:00 2001
From: Eino-Ville Talvala <etalvala@google.com>
Date: Sun, 26 Aug 2012 14:44:38 -0700
Subject: [PATCH] Revert "Camera2: Make static_camera_characteristics const."

Needs a third change that's not yet done with review.

This reverts commit c9ec8a656b59912f496880d3a63c0decd490f09d

Change-Id: Ic3e465e1308cbf107a250ec17b73a59a35e52f9f
---
 include/hardware/camera_common.h |  6 ++----
 tests/camera2/camera2.cpp        | 22 +++++++++++-----------
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/include/hardware/camera_common.h b/include/hardware/camera_common.h
index 5697bda0..5459b6c0 100644
--- a/include/hardware/camera_common.h
+++ b/include/hardware/camera_common.h
@@ -135,9 +135,7 @@ struct camera_info {
 
     /**
      * The camera's fixed characteristics, which include all camera metadata in
-     * the android.*.info.* sections. This should be a sorted metadata buffer,
-     * and may not be modified or freed by the caller. The pointer should remain
-     * valid for the lifetime of the camera module.
+     * the android.*.info.* sections.
      *
      * Version information (based on camera_module_t.common.module_api_version):
      *
@@ -152,7 +150,7 @@ struct camera_info {
      *    otherwise.
      *
      */
-    const camera_metadata_t *static_camera_characteristics;
+    camera_metadata_t *static_camera_characteristics;
 };
 
 typedef struct camera_module {
diff --git a/tests/camera2/camera2.cpp b/tests/camera2/camera2.cpp
index 29eef689..05f61efd 100644
--- a/tests/camera2/camera2.cpp
+++ b/tests/camera2/camera2.cpp
@@ -236,13 +236,13 @@ class Camera2Test: public testing::Test {
     }
 
     void getResolutionList(int32_t format,
-            const int32_t **list,
+            int32_t **list,
             size_t *count) {
         ALOGV("Getting resolutions for format %x", format);
         status_t res;
         if (format != CAMERA2_HAL_PIXEL_FORMAT_OPAQUE) {
-            camera_metadata_ro_entry_t availableFormats;
-            res = find_camera_metadata_ro_entry(mStaticInfo,
+            camera_metadata_entry_t availableFormats;
+            res = find_camera_metadata_entry(mStaticInfo,
                     ANDROID_SCALER_AVAILABLE_FORMATS,
                     &availableFormats);
             ASSERT_EQ(OK, res);
@@ -255,17 +255,17 @@ class Camera2Test: public testing::Test {
                 << "No support found for format 0x" << std::hex << format;
         }
 
-        camera_metadata_ro_entry_t availableSizes;
+        camera_metadata_entry_t availableSizes;
         if (format == HAL_PIXEL_FORMAT_RAW_SENSOR) {
-            res = find_camera_metadata_ro_entry(mStaticInfo,
+            res = find_camera_metadata_entry(mStaticInfo,
                     ANDROID_SCALER_AVAILABLE_RAW_SIZES,
                     &availableSizes);
         } else if (format == HAL_PIXEL_FORMAT_BLOB) {
-            res = find_camera_metadata_ro_entry(mStaticInfo,
+            res = find_camera_metadata_entry(mStaticInfo,
                     ANDROID_SCALER_AVAILABLE_JPEG_SIZES,
                     &availableSizes);
         } else {
-            res = find_camera_metadata_ro_entry(mStaticInfo,
+            res = find_camera_metadata_entry(mStaticInfo,
                     ANDROID_SCALER_AVAILABLE_PROCESSED_SIZES,
                     &availableSizes);
         }
@@ -293,7 +293,7 @@ class Camera2Test: public testing::Test {
     }
 
     camera2_device    *mDevice;
-    const camera_metadata_t *mStaticInfo;
+    camera_metadata_t *mStaticInfo;
 
     MetadataQueue    mRequests;
     MetadataQueue    mFrames;
@@ -342,7 +342,7 @@ TEST_F(Camera2Test, Capture1Raw) {
         sp<FrameWaiter> rawWaiter = new FrameWaiter();
         rawConsumer->setFrameAvailableListener(rawWaiter);
 
-        const int32_t *rawResolutions;
+        int32_t *rawResolutions;
         size_t   rawResolutionsCount;
 
         int format = HAL_PIXEL_FORMAT_RAW_SENSOR;
@@ -456,7 +456,7 @@ TEST_F(Camera2Test, CaptureBurstRaw) {
         sp<FrameWaiter> rawWaiter = new FrameWaiter();
         rawConsumer->setFrameAvailableListener(rawWaiter);
 
-        const int32_t *rawResolutions;
+        int32_t *rawResolutions;
         size_t    rawResolutionsCount;
 
         int format = HAL_PIXEL_FORMAT_RAW_SENSOR;
@@ -618,7 +618,7 @@ TEST_F(Camera2Test, Capture1Jpeg) {
         sp<FrameWaiter> jpegWaiter = new FrameWaiter();
         jpegConsumer->setFrameAvailableListener(jpegWaiter);
 
-        const int32_t *jpegResolutions;
+        int32_t *jpegResolutions;
         size_t   jpegResolutionsCount;
 
         int format = HAL_PIXEL_FORMAT_BLOB;