From 371bc828557989bf81e0eedd2a2907f810ea75f6 Mon Sep 17 00:00:00 2001 From: Arthur Ishiguro Date: Thu, 14 Sep 2023 23:31:27 +0000 Subject: [PATCH] Revert "Increase HidRawSensor thread priority to reduce latency" This reverts commit ae23e944243d531eaba31581cc33b0b49ffeb622. Reason for revert: Possible culprit of b/300512496 Change-Id: Ia99167aa9c979e8afa69ce64f27d535c9228e414 --- .../sensors/dynamic_sensor/HidRawSensorDevice.cpp | 12 +----------- modules/sensors/dynamic_sensor/HidRawSensorDevice.h | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/modules/sensors/dynamic_sensor/HidRawSensorDevice.cpp b/modules/sensors/dynamic_sensor/HidRawSensorDevice.cpp index 5bc4abc2..8aa4cf92 100644 --- a/modules/sensors/dynamic_sensor/HidRawSensorDevice.cpp +++ b/modules/sensors/dynamic_sensor/HidRawSensorDevice.cpp @@ -35,15 +35,6 @@ using namespace Hid::Sensor::PropertyUsage; const std::unordered_set HidRawSensorDevice::sInterested{ ACCELEROMETER_3D, GYROMETER_3D, COMPASS_3D, CUSTOM}; -void HidRawSensorDevice::enableSchedFifoMode() { - constexpr int kHidRawSensorPriority = 10; // Matches with sensor service priority - struct sched_param param = {0}; - param.sched_priority = kHidRawSensorPriority; - if (sched_setscheduler(getTid(), SCHED_FIFO | SCHED_RESET_ON_FORK, ¶m) != 0) { - ALOGE("Couldn't set SCHED_FIFO for HidRawSensor thread: %s", strerror(errno)); - } -} - sp HidRawSensorDevice::create(const std::string &devName) { sp device(new HidRawSensorDevice(devName)); // offset +1 strong count added by constructor @@ -83,8 +74,7 @@ HidRawSensorDevice::HidRawSensorDevice(const std::string &devName) return; } - run("HidRawSensor", PRIORITY_URGENT_DISPLAY); - enableSchedFifoMode(); + run("HidRawSensor"); mValid = true; } diff --git a/modules/sensors/dynamic_sensor/HidRawSensorDevice.h b/modules/sensors/dynamic_sensor/HidRawSensorDevice.h index 7818bf16..06d435e7 100644 --- a/modules/sensors/dynamic_sensor/HidRawSensorDevice.h +++ b/modules/sensors/dynamic_sensor/HidRawSensorDevice.h @@ -41,7 +41,6 @@ private: // constructor will result in +1 strong count explicit HidRawSensorDevice(const std::string &devName); - void enableSchedFifoMode(); // implement function of Thread virtual bool threadLoop() override; std::unordered_map> mSensors;