Replace fields with getters in keepalive API

General guidance is to have getters in the API instead of fields.

Fixes: 181014882
Test: m
Change-Id: Id4bfc447701e8d0380163047779fbba043f17b6f
This commit is contained in:
Remi NGUYEN VAN
2021-04-08 13:59:10 +09:00
parent cb20318619
commit 019b0eef3c
2 changed files with 79 additions and 12 deletions

View File

@@ -32,22 +32,39 @@ import java.util.Objects;
public final class TcpKeepalivePacketData extends KeepalivePacketData implements Parcelable {
private static final String TAG = "TcpKeepalivePacketData";
/** TCP sequence number. */
/**
* TCP sequence number.
* @hide
*/
public final int tcpSeq;
/** TCP ACK number. */
/**
* TCP ACK number.
* @hide
*/
public final int tcpAck;
/** TCP RCV window. */
/**
* TCP RCV window.
* @hide
*/
public final int tcpWindow;
/** TCP RCV window scale. */
/** TCP RCV window scale.
* @hide
*/
public final int tcpWindowScale;
/** IP TOS. */
/**
* IP TOS.
* @hide
*/
public final int ipTos;
/** IP TTL. */
/**
* IP TTL.
* @hide
*/
public final int ipTtl;
public TcpKeepalivePacketData(@NonNull final InetAddress srcAddress, int srcPort,
@@ -63,6 +80,56 @@ public final class TcpKeepalivePacketData extends KeepalivePacketData implements
this.ipTtl = ipTtl;
}
/**
* Get the TCP sequence number.
*
* See https://tools.ietf.org/html/rfc793#page-15.
*/
public int getTcpSeq() {
return tcpSeq;
}
/**
* Get the TCP ACK number.
*
* See https://tools.ietf.org/html/rfc793#page-15.
*/
public int getTcpAck() {
return tcpAck;
}
/**
* Get the TCP RCV window.
*
* See https://tools.ietf.org/html/rfc793#page-15.
*/
public int getTcpWindow() {
return tcpWindow;
}
/**
* Get the TCP RCV window scale.
*
* See https://tools.ietf.org/html/rfc793#page-15.
*/
public int getTcpWindowScale() {
return tcpWindowScale;
}
/**
* Get the IP type of service.
*/
public int getIpTos() {
return ipTos;
}
/**
* Get the IP TTL.
*/
public int getIpTtl() {
return ipTtl;
}
@Override
public boolean equals(@Nullable final Object o) {
if (!(o instanceof TcpKeepalivePacketData)) return false;