Merge "A minor followup change for BPF offload device option stuff" am: 88536883e2

Change-Id: Id2f86ebd0668d27eb6002ead9f0a659b26c62c58
This commit is contained in:
Maciej Żenczykowski
2020-05-12 18:52:10 +00:00
committed by Automerger Merge Worker
3 changed files with 8 additions and 8 deletions

View File

@@ -57,7 +57,7 @@
<!-- Use the BPF offload for tethering when the kernel has support. True by default.
If the device doesn't want to support tether BPF offload, this should be false.
Note that this setting could be override by device config.
Note that this setting could be overridden by device config.
-->
<bool translatable="false" name="config_tether_enable_bpf_offload">true</bool>

View File

@@ -25,7 +25,7 @@
<item type="array" name="config_tether_dhcp_range"/>
<!-- Use the BPF offload for tethering when the kernel has support. True by default.
If the device doesn't want to support tether BPF offload, this should be false.
Note that this setting could be override by device config.
Note that this setting could be overridden by device config.
-->
<item type="bool" name="config_tether_enable_bpf_offload"/>
<item type="bool" name="config_tether_enable_legacy_dhcp_server"/>

View File

@@ -303,6 +303,8 @@ public class IpServer extends StateMachine {
private final IpNeighborMonitor mIpNeighborMonitor;
// TODO: Add a dependency object to pass the data members or variables from the tethering
// object. It helps to reduce the arguments of the constructor.
public IpServer(
String ifaceName, Looper looper, int interfaceType, SharedLog log,
INetd netd, Callback callback, boolean usingLegacyDhcp, boolean usingBpfOffload,
@@ -325,14 +327,12 @@ public class IpServer extends StateMachine {
mIpNeighborMonitor = mDeps.getIpNeighborMonitor(getHandler(), mLog,
new MyNeighborEventConsumer());
// IP neighbor monitor monitors the neighbor event for adding/removing offload
// IP neighbor monitor monitors the neighbor events for adding/removing offload
// forwarding rules per client. If BPF offload is not supported, don't start listening
// neighbor events. See updateIpv6ForwardingRules, addIpv6ForwardingRule,
// for neighbor events. See updateIpv6ForwardingRules, addIpv6ForwardingRule,
// removeIpv6ForwardingRule.
if (mUsingBpfOffload) {
if (!mIpNeighborMonitor.start()) {
mLog.e("Failed to create IpNeighborMonitor on " + mIfaceName);
}
if (mUsingBpfOffload && !mIpNeighborMonitor.start()) {
mLog.e("Failed to create IpNeighborMonitor on " + mIfaceName);
}
mInitialState = new InitialState();