From 0e0ae8a849a052ff9e01b82f3710ddba13f7eb4d Mon Sep 17 00:00:00 2001 From: Robert Greenwalt Date: Fri, 22 Feb 2013 14:57:00 -0800 Subject: [PATCH] Remove two new permission checks These checks while technically reasonable are a hard to swallow API change that may break existing apps and pragmatically serves no purpose: the protected data is available in publicly readable java VM properties. Change-Id: I522c493c2604a33e28d99e2be31054326c9a8323 --- .../java/com/android/server/ConnectivityService.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/services/java/com/android/server/ConnectivityService.java b/services/java/com/android/server/ConnectivityService.java index 7abd530b27..5e4855b360 100644 --- a/services/java/com/android/server/ConnectivityService.java +++ b/services/java/com/android/server/ConnectivityService.java @@ -2999,7 +2999,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { } public ProxyProperties getProxy() { - enforceAccessPermission(); + // this information is already available as a world read/writable jvm property + // so this API change wouldn't have a benifit. It also breaks the passing + // of proxy info to all the JVMs. + // enforceAccessPermission(); synchronized (mDefaultProxyLock) { return mDefaultProxyDisabled ? null : mDefaultProxy; } @@ -3051,7 +3054,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { } public ProxyProperties getGlobalProxy() { - enforceAccessPermission(); + // this information is already available as a world read/writable jvm property + // so this API change wouldn't have a benifit. It also breaks the passing + // of proxy info to all the JVMs. + // enforceAccessPermission(); synchronized (mGlobalProxyLock) { return mGlobalProxy; }