LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix NullPointerException on NsdService

Browse Source 
The NsdService will throw a NPE if a new client is registered
with a null INsdManagerCallback object. To avoid this, perform
a null check before registering a new client and throw an
IllegalArgumentException if the callback is null.

Bug: 293285797
Test: atest FrameworksNetTests
Change-Id: Id61e27873591031c3fe383879aee0d40eebc08b3
This commit is contained in:
Paul Hu
2023-08-09 16:05:20 +08:00
parent 8ba50ae30f
commit 101dbf5262
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
service-t/src/com/android/server/NsdService.java
View File

@@ -1920,11 +1920,14 @@ public class NsdService extends INsdManager.Stub {
@Override
public INsdServiceConnector connect(INsdManagerCallback cb, boolean useJavaBackend) {
mContext.enforceCallingOrSelfPermission(android.Manifest.permission.INTERNET, "NsdService");
final int uid = mDeps.getCallingUid();
if (cb == null) {
throw new IllegalArgumentException("Unknown client callback from uid=" + uid);
}
if (DBG) Log.d(TAG, "New client connect. useJavaBackend=" + useJavaBackend);
final INsdServiceConnector connector = new NsdServiceConnector();
mNsdStateMachine.sendMessage(mNsdStateMachine.obtainMessage(NsdManager.REGISTER_CLIENT,
new ConnectorArgs((NsdServiceConnector) connector, cb, useJavaBackend,
mDeps.getCallingUid())));
new ConnectorArgs((NsdServiceConnector) connector, cb, useJavaBackend, uid)));
return connector;
}

14
tests/unit/java/com/android/server/NsdServiceTest.java
View File

@@ -1585,6 +1585,20 @@ public class NsdServiceTest {
lockOrder.verify(mMulticastLock).release();
}
@Test
public void testNullINsdManagerCallback() {
final NsdService service = new NsdService(mContext, mHandler, CLEANUP_DELAY_MS, mDeps) {
@Override
public INsdServiceConnector connect(INsdManagerCallback baseCb,
boolean runNewMdnsBackend) {
// Pass null INsdManagerCallback
return super.connect(null /* cb */, runNewMdnsBackend);
}
};
assertThrows(IllegalArgumentException.class, () -> new NsdManager(mContext, service));
}
private void waitForIdle() {
HandlerUtils.waitForIdle(mHandler, TIMEOUT_MS);
}