Add jarjar rules generator

(This rolls forward part of a previous change, now that jarjar was fixed
to not get very slow when the number of rules increases).

Jarjar rules are hard to keep in sync with code, and hard to maintain
manually as the distinction between what should and should not be
jarjared is not always clear. This results in unsafe binaries that are
manually maintained, and developer frustration when something fails due
to incorrect jarjar rules.

Add utility to autogenerate jarjar rules, which can be run at build time
time (via a genrule) instead. The generator scans pre-jarjar
intermediate artifacts, and outputs jarjar rules for every class to put
it in a package specific to the module. The only exceptions are:

 - Classes that are API (module-lib API is the largest API surface of
   the module, so module-lib API stubs would typically be used)
 - Classes that have unsupportedappusage symbols
 - Classes that are excluded manually (for example, because they have
   hardcoded external references, like for
   ConnectivityServiceInitializer in SystemServer).

Bug: 217129444
Test: atest jarjar-rules-generator-test;

Change-Id: I3493957e39a661b6c2e330944e7c3023b8f3203e
This commit is contained in:
Remi NGUYEN VAN
2022-05-24 16:47:33 +09:00
parent a632356e05
commit 11f162b5f8
11 changed files with 410 additions and 0 deletions

133
tools/gen_jarjar.py Executable file
View File

@@ -0,0 +1,133 @@
#
# Copyright (C) 2022 The Android Open Source Project
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
""" This script generates jarjar rule files to add a jarjar prefix to all classes, except those
that are API, unsupported API or otherwise excluded."""
import argparse
import io
import re
import subprocess
from xml import sax
from xml.sax.handler import ContentHandler
from zipfile import ZipFile
def parse_arguments(argv):
parser = argparse.ArgumentParser()
parser.add_argument(
'--jars', nargs='+',
help='Path to pre-jarjar JAR. Can be followed by multiple space-separated paths.')
parser.add_argument(
'--prefix', required=True,
help='Package prefix to use for jarjared classes, '
'for example "com.android.connectivity" (does not end with a dot).')
parser.add_argument(
'--output', required=True, help='Path to output jarjar rules file.')
parser.add_argument(
'--apistubs', nargs='*', default=[],
help='Path to API stubs jar. Classes that are API will not be jarjared. Can be followed by '
'multiple space-separated paths.')
parser.add_argument(
'--unsupportedapi', nargs='*', default=[],
help='Path to UnsupportedAppUsage hidden API .txt lists. '
'Classes that have UnsupportedAppUsage API will not be jarjared. Can be followed by '
'multiple space-separated paths.')
parser.add_argument(
'--excludes', nargs='*', default=[],
help='Path to files listing classes that should not be jarjared. Can be followed by '
'multiple space-separated paths. '
'Each file should contain one full-match regex per line. Empty lines or lines '
'starting with "#" are ignored.')
return parser.parse_args(argv)
def _list_toplevel_jar_classes(jar):
"""List all classes in a .class .jar file that are not inner classes."""
return {_get_toplevel_class(c) for c in _list_jar_classes(jar)}
def _list_jar_classes(jar):
with ZipFile(jar, 'r') as zip:
files = zip.namelist()
assert 'classes.dex' not in files, f'Jar file {jar} is dexed, ' \
'expected an intermediate zip of .class files'
class_len = len('.class')
return [f.replace('/', '.')[:-class_len] for f in files
if f.endswith('.class') and not f.endswith('/package-info.class')]
def _list_hiddenapi_classes(txt_file):
out = set()
with open(txt_file, 'r') as f:
for line in f:
if not line.strip():
continue
assert line.startswith('L') and ';' in line, f'Class name not recognized: {line}'
clazz = line.replace('/', '.').split(';')[0][1:]
out.add(_get_toplevel_class(clazz))
return out
def _get_toplevel_class(clazz):
"""Return the name of the toplevel (not an inner class) enclosing class of the given class."""
if '$' not in clazz:
return clazz
return clazz.split('$')[0]
def _get_excludes(path):
out = []
with open(path, 'r') as f:
for line in f:
stripped = line.strip()
if not stripped or stripped.startswith('#'):
continue
out.append(re.compile(stripped))
return out
def make_jarjar_rules(args):
excluded_classes = set()
for apistubs_file in args.apistubs:
excluded_classes.update(_list_toplevel_jar_classes(apistubs_file))
for unsupportedapi_file in args.unsupportedapi:
excluded_classes.update(_list_hiddenapi_classes(unsupportedapi_file))
exclude_regexes = []
for exclude_file in args.excludes:
exclude_regexes.extend(_get_excludes(exclude_file))
with open(args.output, 'w') as outfile:
for jar in args.jars:
jar_classes = _list_jar_classes(jar)
jar_classes.sort()
for clazz in jar_classes:
if (_get_toplevel_class(clazz) not in excluded_classes and
not any(r.fullmatch(clazz) for r in exclude_regexes)):
outfile.write(f'rule {clazz} {args.prefix}.@0\n')
# Also include jarjar rules for unit tests of the class, so the package matches
outfile.write(f'rule {clazz}Test {args.prefix}.@0\n')
outfile.write(f'rule {clazz}Test$* {args.prefix}.@0\n')
def _main():
# Pass in None to use argv
args = parse_arguments(None)
make_jarjar_rules(args)
if __name__ == '__main__':
_main()