LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "Improve keepalive offload documentation and error handling" am: a0b880c9e8 am: 4a91c73e67

Browse Source 
am: a820236f47

Change-Id: If13af1a50c9bb12c85559c9c7a83d0e861d76d09
This commit is contained in:
Junyu Lai
2019-03-11 22:40:00 -07:00
committed by android-build-merger
parent 05613209e6 a820236f47
commit 16f5c7d596
3 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/java/android/net/TcpSocketKeepalive.java
View File

@@ -45,13 +45,14 @@ final class TcpSocketKeepalive extends SocketKeepalive {
* - The application must not write to or read from the socket after calling this method, until
* onDataReceived, onStopped, or onError are called. If it does, the keepalive will fail
* with {@link #ERROR_SOCKET_NOT_IDLE}, or {@code #ERROR_INVALID_SOCKET} if the socket
* experienced an error (as in poll(2) returned POLLERR); if this happens, the data received
* from the socket may be invalid, and the socket can't be recovered.
* experienced an error (as in poll(2) returned POLLERR or POLLHUP); if this happens, the data
* received from the socket may be invalid, and the socket can't be recovered.
* - If the socket has data in the send or receive buffer, then this call will fail with
* {@link #ERROR_SOCKET_NOT_IDLE} and can be retried after the data has been processed.
* An app could ensure this by using an application-layer protocol where it can receive
* acknowledgement that it will go into keepalive mode. It could then go into keepalive
* mode after having read the acknowledgement, draining the socket.
* An app could ensure this by using an application-layer protocol to receive acknowledgement
* that indicates all data has been delivered to server, e.g. HTTP 200 OK.
* Then the app could go into keepalive mode after reading all remaining data within the
* acknowledgement.
*/
@Override
void startImpl(int intervalSec) {