From 477db5fe1af5b417ccbb418da4710a1fe921d7d2 Mon Sep 17 00:00:00 2001 From: Luke Huang Date: Fri, 19 Oct 2018 15:57:05 +0900 Subject: [PATCH] Refactor UidRange by using stable aidl structure Use stable aidl generated structure instead of UidRange Test: runtest frameworks-net passes Test: manual testing of UidRange related function works Change-Id: Iaf1c10777dc1e71df2be2a57533a10257b12626b --- core/java/android/net/UidRange.java | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/core/java/android/net/UidRange.java b/core/java/android/net/UidRange.java index 3164929943..793c82dc68 100644 --- a/core/java/android/net/UidRange.java +++ b/core/java/android/net/UidRange.java @@ -19,17 +19,14 @@ package android.net; import static android.os.UserHandle.PER_USER_RANGE; import android.os.Parcel; -import android.os.Parcelable; /** * An inclusive range of UIDs. * * @hide */ -public final class UidRange implements Parcelable { - public final int start; - public final int stop; - +public final class UidRange extends UidRangeParcel { + private UidRange() {} public UidRange(int startUid, int stopUid) { if (startUid < 0) throw new IllegalArgumentException("Invalid start UID."); if (stopUid < 0) throw new IllegalArgumentException("Invalid stop UID."); @@ -89,26 +86,18 @@ public final class UidRange implements Parcelable { return start + "-" + stop; } - // implement the Parcelable interface - @Override - public int describeContents() { - return 0; - } - - @Override - public void writeToParcel(Parcel dest, int flags) { - dest.writeInt(start); - dest.writeInt(stop); - } + /** + * DO NOT override "writeToParcel" and "readFromParcel" in this class. + * The parceling code is autogenerated by the superclass. + */ public static final Creator CREATOR = new Creator() { @Override public UidRange createFromParcel(Parcel in) { - int start = in.readInt(); - int stop = in.readInt(); - - return new UidRange(start, stop); + UidRange obj = new UidRange(); + obj.readFromParcel(in); + return obj; } @Override public UidRange[] newArray(int size) {