LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop requiring CHANGE_NETWORK_STATE to change Ethernet config.

Browse Source 
Requiring CHANGE_NETWORK_STATE is pointless, since immediately
after doing that we require CONNECTIVITY_INTERNAL, which is
a system-only permission.

Bug: 23597341
Change-Id: If4c8ecbb319e547c2c81d2dcc3c7bbb63e0bc2af
This commit is contained in:
Lorenzo Colitti
2015-10-15 16:59:07 +09:00
parent baabe41348
commit 189063ffb0
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
service-t/src/com/android/server/ethernet/EthernetServiceImpl.java
View File

@@ -74,12 +74,6 @@ public class EthernetServiceImpl extends IEthernetManager.Stub {
"EthernetService"); "EthernetService");
} }
private void enforceChangePermission() {
int uid = Binder.getCallingUid();
Settings.checkAndNoteChangeNetworkStateOperation(mContext, uid, Settings
.getPackageNameForUid(mContext, uid), true);
}
private void enforceConnectivityInternalPermission() { private void enforceConnectivityInternalPermission() {
mContext.enforceCallingOrSelfPermission( mContext.enforceCallingOrSelfPermission(
android.Manifest.permission.CONNECTIVITY_INTERNAL, android.Manifest.permission.CONNECTIVITY_INTERNAL,
@@ -120,7 +114,6 @@ public class EthernetServiceImpl extends IEthernetManager.Stub {
Log.w(TAG, "System isn't ready enough to change ethernet configuration"); Log.w(TAG, "System isn't ready enough to change ethernet configuration");
} }
enforceChangePermission();
enforceConnectivityInternalPermission(); enforceConnectivityInternalPermission();
synchronized (mIpConfiguration) { synchronized (mIpConfiguration) {