diff --git a/service-t/src/com/android/server/net/NetworkStatsService.java b/service-t/src/com/android/server/net/NetworkStatsService.java index 4d04461e40..424dcd999d 100644 --- a/service-t/src/com/android/server/net/NetworkStatsService.java +++ b/service-t/src/com/android/server/net/NetworkStatsService.java @@ -1126,9 +1126,7 @@ public class NetworkStatsService extends INetworkStatsService.Stub { } catch (Resources.NotFoundException e) { // Overlay value is not defined. } - // TODO(b/233752318): For now it is always true to collect signal from beta users. - // Should change to the default behavior (true if debuggable builds) before formal release. - return (overlayValue != null ? overlayValue : mDeps.isDebuggable()) || true; + return overlayValue != null ? overlayValue : mDeps.isDebuggable(); } /** diff --git a/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java b/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java index 43c75b742a..f9cbb106f1 100644 --- a/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java +++ b/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java @@ -2000,15 +2000,30 @@ public class NetworkStatsServiceTest extends NetworkStatsBaseTest { @Test public void testShouldRunComparison() { - // TODO(b/233752318): For now it should always true to collect signal from beta users. - // Should change to the default behavior (true if userdebug rom) before formal release. - for (int testValue : Set.of(-1, 0, 1, 2)) { - doReturn(testValue).when(mResources) + for (Boolean isDebuggable : Set.of(Boolean.TRUE, Boolean.FALSE)) { + mIsDebuggable = isDebuggable; + // Verify return false regardless of the device is debuggable. + doReturn(0).when(mResources) .getInteger(R.integer.config_netstats_validate_import); - assertEquals(true, mService.shouldRunComparison()); + assertShouldRunComparison(false, isDebuggable); + // Verify return true regardless of the device is debuggable. + doReturn(1).when(mResources) + .getInteger(R.integer.config_netstats_validate_import); + assertShouldRunComparison(true, isDebuggable); + // Verify return true iff the device is debuggable. + for (int testValue : Set.of(-1, 2)) { + doReturn(testValue).when(mResources) + .getInteger(R.integer.config_netstats_validate_import); + assertShouldRunComparison(isDebuggable, isDebuggable); + } } } + private void assertShouldRunComparison(boolean expected, boolean isDebuggable) { + assertEquals("shouldRunComparison (debuggable=" + isDebuggable + "): ", + expected, mService.shouldRunComparison()); + } + private NetworkStatsRecorder makeTestRecorder(File directory, String prefix, Config config, boolean includeTags, boolean wipeOnError) { final NetworkStats.NonMonotonicObserver observer =