LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge changes I4872f8ba,I92039f29,Iaad13e13 am: 767ac317e2 am: 717238a614

Browse Source 
am: 44e9b81c54

Change-Id: I9c38d1254f82b50f4d1e953e72bf15a46562d3b8
This commit is contained in:
Hugo Benichi
2017-05-09 06:30:48 +00:00
committed by android-build-merger
parent 284ecaa201 d2552aee11
commit 20f5ef9065
2 changed files with 103 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

182
core/java/android/net/nsd/NsdManager.java
View File

@@ -16,6 +16,10 @@
package android.net.nsd; package android.net.nsd;
import static com.android.internal.util.Preconditions.checkArgument;
import static com.android.internal.util.Preconditions.checkNotNull;
import static com.android.internal.util.Preconditions.checkStringNotEmpty;
import android.annotation.SdkConstant; import android.annotation.SdkConstant;
import android.annotation.SdkConstant.SdkConstantType; import android.annotation.SdkConstant.SdkConstantType;
import android.content.Context; import android.content.Context;
@@ -241,12 +245,12 @@ public final class NsdManager {
return name; return name;
} }
private static int FIRST_LISTENER_KEY = 1;
private final INsdManager mService; private final INsdManager mService;
private final Context mContext; private final Context mContext;
private static final int INVALID_LISTENER_KEY = 0; private int mListenerKey = FIRST_LISTENER_KEY;
private static final int BUSY_LISTENER_KEY = -1;
private int mListenerKey = 1;
private final SparseArray mListenerMap = new SparseArray(); private final SparseArray mListenerMap = new SparseArray();
private final SparseArray<NsdServiceInfo> mServiceMap = new SparseArray<>(); private final SparseArray<NsdServiceInfo> mServiceMap = new SparseArray<>();
private final Object mMapLock = new Object(); private final Object mMapLock = new Object();
@@ -269,6 +273,14 @@ public final class NsdManager {
init(); init();
} }
/**
* @hide
*/
@VisibleForTesting
public void disconnect() {
mAsyncChannel.disconnect();
}
/** /**
* Failures are passed with {@link RegistrationListener#onRegistrationFailed}, * Failures are passed with {@link RegistrationListener#onRegistrationFailed},
* {@link RegistrationListener#onUnregistrationFailed}, * {@link RegistrationListener#onUnregistrationFailed},
@@ -304,7 +316,6 @@ public final class NsdManager {
public void onServiceFound(NsdServiceInfo serviceInfo); public void onServiceFound(NsdServiceInfo serviceInfo);
public void onServiceLost(NsdServiceInfo serviceInfo); public void onServiceLost(NsdServiceInfo serviceInfo);
} }
/** Interface for callback invocation for service registration */ /** Interface for callback invocation for service registration */
@@ -335,8 +346,9 @@ public final class NsdManager {
@Override @Override
public void handleMessage(Message message) { public void handleMessage(Message message) {
if (DBG) Log.d(TAG, "received " + nameOf(message.what)); final int what = message.what;
switch (message.what) { final int key = message.arg2;
switch (what) {
case AsyncChannel.CMD_CHANNEL_HALF_CONNECTED: case AsyncChannel.CMD_CHANNEL_HALF_CONNECTED:
mAsyncChannel.sendMessage(AsyncChannel.CMD_CHANNEL_FULL_CONNECTION); mAsyncChannel.sendMessage(AsyncChannel.CMD_CHANNEL_FULL_CONNECTION);
return; return;
@@ -349,19 +361,26 @@ public final class NsdManager {
default: default:
break; break;
} }
Object listener = getListener(message.arg2); final Object listener;
final NsdServiceInfo ns;
synchronized (mMapLock) {
listener = mListenerMap.get(key);
ns = mServiceMap.get(key);
}
if (listener == null) { if (listener == null) {
Log.d(TAG, "Stale key " + message.arg2); Log.d(TAG, "Stale key " + message.arg2);
return; return;
} }
NsdServiceInfo ns = getNsdService(message.arg2); if (DBG) {
switch (message.what) { Log.d(TAG, "received " + nameOf(what) + " for key " + key + ", service " + ns);
}
switch (what) {
case DISCOVER_SERVICES_STARTED: case DISCOVER_SERVICES_STARTED:
String s = getNsdServiceInfoType((NsdServiceInfo) message.obj); String s = getNsdServiceInfoType((NsdServiceInfo) message.obj);
((DiscoveryListener) listener).onDiscoveryStarted(s); ((DiscoveryListener) listener).onDiscoveryStarted(s);
break; break;
case DISCOVER_SERVICES_FAILED: case DISCOVER_SERVICES_FAILED:
removeListener(message.arg2); removeListener(key);
((DiscoveryListener) listener).onStartDiscoveryFailed(getNsdServiceInfoType(ns), ((DiscoveryListener) listener).onStartDiscoveryFailed(getNsdServiceInfoType(ns),
message.arg1); message.arg1);
break; break;
@@ -374,16 +393,16 @@ public final class NsdManager {
case STOP_DISCOVERY_FAILED: case STOP_DISCOVERY_FAILED:
// TODO: failure to stop discovery should be internal and retried internally, as // TODO: failure to stop discovery should be internal and retried internally, as
// the effect for the client is indistinguishable from STOP_DISCOVERY_SUCCEEDED // the effect for the client is indistinguishable from STOP_DISCOVERY_SUCCEEDED
removeListener(message.arg2); removeListener(key);
((DiscoveryListener) listener).onStopDiscoveryFailed(getNsdServiceInfoType(ns), ((DiscoveryListener) listener).onStopDiscoveryFailed(getNsdServiceInfoType(ns),
message.arg1); message.arg1);
break; break;
case STOP_DISCOVERY_SUCCEEDED: case STOP_DISCOVERY_SUCCEEDED:
removeListener(message.arg2); removeListener(key);
((DiscoveryListener) listener).onDiscoveryStopped(getNsdServiceInfoType(ns)); ((DiscoveryListener) listener).onDiscoveryStopped(getNsdServiceInfoType(ns));
break; break;
case REGISTER_SERVICE_FAILED: case REGISTER_SERVICE_FAILED:
removeListener(message.arg2); removeListener(key);
((RegistrationListener) listener).onRegistrationFailed(ns, message.arg1); ((RegistrationListener) listener).onRegistrationFailed(ns, message.arg1);
break; break;
case REGISTER_SERVICE_SUCCEEDED: case REGISTER_SERVICE_SUCCEEDED:
@@ -391,7 +410,7 @@ public final class NsdManager {
(NsdServiceInfo) message.obj); (NsdServiceInfo) message.obj);
break; break;
case UNREGISTER_SERVICE_FAILED: case UNREGISTER_SERVICE_FAILED:
removeListener(message.arg2); removeListener(key);
((RegistrationListener) listener).onUnregistrationFailed(ns, message.arg1); ((RegistrationListener) listener).onUnregistrationFailed(ns, message.arg1);
break; break;
case UNREGISTER_SERVICE_SUCCEEDED: case UNREGISTER_SERVICE_SUCCEEDED:
@@ -401,11 +420,11 @@ public final class NsdManager {
((RegistrationListener) listener).onServiceUnregistered(ns); ((RegistrationListener) listener).onServiceUnregistered(ns);
break; break;
case RESOLVE_SERVICE_FAILED: case RESOLVE_SERVICE_FAILED:
removeListener(message.arg2); removeListener(key);
((ResolveListener) listener).onResolveFailed(ns, message.arg1); ((ResolveListener) listener).onResolveFailed(ns, message.arg1);
break; break;
case RESOLVE_SERVICE_SUCCEEDED: case RESOLVE_SERVICE_SUCCEEDED:
removeListener(message.arg2); removeListener(key);
((ResolveListener) listener).onServiceResolved((NsdServiceInfo) message.obj); ((ResolveListener) listener).onServiceResolved((NsdServiceInfo) message.obj);
break; break;
default: default:
@@ -415,40 +434,27 @@ public final class NsdManager {
} }
} }
// if the listener is already in the map, reject it. Otherwise, add it and private int nextListenerKey() {
// return its key. // Ensure mListenerKey >= FIRST_LISTENER_KEY;
mListenerKey = Math.max(FIRST_LISTENER_KEY, mListenerKey + 1);
return mListenerKey;
}
// Assert that the listener is not in the map, then add it and returns its key
private int putListener(Object listener, NsdServiceInfo s) { private int putListener(Object listener, NsdServiceInfo s) {
if (listener == null) return INVALID_LISTENER_KEY; checkListener(listener);
int key; final int key;
synchronized (mMapLock) { synchronized (mMapLock) {
int valueIndex = mListenerMap.indexOfValue(listener); int valueIndex = mListenerMap.indexOfValue(listener);
if (valueIndex != -1) { checkArgument(valueIndex == -1, "listener already in use");
return BUSY_LISTENER_KEY; key = nextListenerKey();
}
do {
key = mListenerKey++;
} while (key == INVALID_LISTENER_KEY);
mListenerMap.put(key, listener); mListenerMap.put(key, listener);
mServiceMap.put(key, s); mServiceMap.put(key, s);
} }
return key; return key;
} }
private Object getListener(int key) {
if (key == INVALID_LISTENER_KEY) return null;
synchronized (mMapLock) {
return mListenerMap.get(key);
}
}
private NsdServiceInfo getNsdService(int key) {
synchronized (mMapLock) {
return mServiceMap.get(key);
}
}
private void removeListener(int key) { private void removeListener(int key) {
if (key == INVALID_LISTENER_KEY) return;
synchronized (mMapLock) { synchronized (mMapLock) {
mListenerMap.remove(key); mListenerMap.remove(key);
mServiceMap.remove(key); mServiceMap.remove(key);
@@ -456,16 +462,15 @@ public final class NsdManager {
} }
private int getListenerKey(Object listener) { private int getListenerKey(Object listener) {
checkListener(listener);
synchronized (mMapLock) { synchronized (mMapLock) {
int valueIndex = mListenerMap.indexOfValue(listener); int valueIndex = mListenerMap.indexOfValue(listener);
if (valueIndex != -1) { checkArgument(valueIndex != -1, "listener not registered");
return mListenerMap.keyAt(valueIndex); return mListenerMap.keyAt(valueIndex);
} }
} }
return INVALID_LISTENER_KEY;
}
private String getNsdServiceInfoType(NsdServiceInfo s) { private static String getNsdServiceInfoType(NsdServiceInfo s) {
if (s == null) return "?"; if (s == null) return "?";
return s.getServiceType(); return s.getServiceType();
} }
@@ -475,7 +480,9 @@ public final class NsdManager {
*/ */
private void init() { private void init() {
final Messenger messenger = getMessenger(); final Messenger messenger = getMessenger();
if (messenger == null) throw new RuntimeException("Failed to initialize"); if (messenger == null) {
fatal("Failed to obtain service Messenger");
}
HandlerThread t = new HandlerThread("NsdManager"); HandlerThread t = new HandlerThread("NsdManager");
t.start(); t.start();
mHandler = new ServiceHandler(t.getLooper()); mHandler = new ServiceHandler(t.getLooper());
@@ -483,10 +490,15 @@ public final class NsdManager {
try { try {
mConnected.await(); mConnected.await();
} catch (InterruptedException e) { } catch (InterruptedException e) {
Log.e(TAG, "interrupted wait at init"); fatal("Interrupted wait at init");
} }
} }
private static void fatal(String msg) {
Log.e(TAG, msg);
throw new RuntimeException(msg);
}
/** /**
* Register a service to be discovered by other services. * Register a service to be discovered by other services.
* *
@@ -506,23 +518,10 @@ public final class NsdManager {
*/ */
public void registerService(NsdServiceInfo serviceInfo, int protocolType, public void registerService(NsdServiceInfo serviceInfo, int protocolType,
RegistrationListener listener) { RegistrationListener listener) {
if (TextUtils.isEmpty(serviceInfo.getServiceName()) || checkArgument(serviceInfo.getPort() > 0, "Invalid port number");
TextUtils.isEmpty(serviceInfo.getServiceType())) { checkServiceInfo(serviceInfo);
throw new IllegalArgumentException("Service name or type cannot be empty"); checkProtocol(protocolType);
}
if (serviceInfo.getPort() <= 0) {
throw new IllegalArgumentException("Invalid port number");
}
if (listener == null) {
throw new IllegalArgumentException("listener cannot be null");
}
if (protocolType != PROTOCOL_DNS_SD) {
throw new IllegalArgumentException("Unsupported protocol");
}
int key = putListener(listener, serviceInfo); int key = putListener(listener, serviceInfo);
if (key == BUSY_LISTENER_KEY) {
throw new IllegalArgumentException("listener already in use");
}
mAsyncChannel.sendMessage(REGISTER_SERVICE, 0, key, serviceInfo); mAsyncChannel.sendMessage(REGISTER_SERVICE, 0, key, serviceInfo);
} }
@@ -541,12 +540,6 @@ public final class NsdManager {
*/ */
public void unregisterService(RegistrationListener listener) { public void unregisterService(RegistrationListener listener) {
int id = getListenerKey(listener); int id = getListenerKey(listener);
if (id == INVALID_LISTENER_KEY) {
throw new IllegalArgumentException("listener not registered");
}
if (listener == null) {
throw new IllegalArgumentException("listener cannot be null");
}
mAsyncChannel.sendMessage(UNREGISTER_SERVICE, 0, id); mAsyncChannel.sendMessage(UNREGISTER_SERVICE, 0, id);
} }
@@ -579,25 +572,13 @@ public final class NsdManager {
* Cannot be null. Cannot be in use for an active service discovery. * Cannot be null. Cannot be in use for an active service discovery.
*/ */
public void discoverServices(String serviceType, int protocolType, DiscoveryListener listener) { public void discoverServices(String serviceType, int protocolType, DiscoveryListener listener) {
if (listener == null) { checkStringNotEmpty(serviceType, "Service type cannot be empty");
throw new IllegalArgumentException("listener cannot be null"); checkProtocol(protocolType);
}
if (TextUtils.isEmpty(serviceType)) {
throw new IllegalArgumentException("Service type cannot be empty");
}
if (protocolType != PROTOCOL_DNS_SD) {
throw new IllegalArgumentException("Unsupported protocol");
}
NsdServiceInfo s = new NsdServiceInfo(); NsdServiceInfo s = new NsdServiceInfo();
s.setServiceType(serviceType); s.setServiceType(serviceType);
int key = putListener(listener, s); int key = putListener(listener, s);
if (key == BUSY_LISTENER_KEY) {
throw new IllegalArgumentException("listener already in use");
}
mAsyncChannel.sendMessage(DISCOVER_SERVICES, 0, key, s); mAsyncChannel.sendMessage(DISCOVER_SERVICES, 0, key, s);
} }
@@ -619,12 +600,6 @@ public final class NsdManager {
*/ */
public void stopServiceDiscovery(DiscoveryListener listener) { public void stopServiceDiscovery(DiscoveryListener listener) {
int id = getListenerKey(listener); int id = getListenerKey(listener);
if (id == INVALID_LISTENER_KEY) {
throw new IllegalArgumentException("service discovery not active on listener");
}
if (listener == null) {
throw new IllegalArgumentException("listener cannot be null");
}
mAsyncChannel.sendMessage(STOP_DISCOVERY, 0, id); mAsyncChannel.sendMessage(STOP_DISCOVERY, 0, id);
} }
@@ -638,19 +613,8 @@ public final class NsdManager {
* Cannot be in use for an active service resolution. * Cannot be in use for an active service resolution.
*/ */
public void resolveService(NsdServiceInfo serviceInfo, ResolveListener listener) { public void resolveService(NsdServiceInfo serviceInfo, ResolveListener listener) {
if (TextUtils.isEmpty(serviceInfo.getServiceName()) || checkServiceInfo(serviceInfo);
TextUtils.isEmpty(serviceInfo.getServiceType())) {
throw new IllegalArgumentException("Service name or type cannot be empty");
}
if (listener == null) {
throw new IllegalArgumentException("listener cannot be null");
}
int key = putListener(listener, serviceInfo); int key = putListener(listener, serviceInfo);
if (key == BUSY_LISTENER_KEY) {
throw new IllegalArgumentException("listener already in use");
}
mAsyncChannel.sendMessage(RESOLVE_SERVICE, 0, key, serviceInfo); mAsyncChannel.sendMessage(RESOLVE_SERVICE, 0, key, serviceInfo);
} }
@@ -664,10 +628,10 @@ public final class NsdManager {
} }
/** /**
* Get a reference to NetworkService handler. This is used to establish * Get a reference to NsdService handler. This is used to establish
* an AsyncChannel communication with the service * an AsyncChannel communication with the service
* *
* @return Messenger pointing to the NetworkService handler * @return Messenger pointing to the NsdService handler
*/ */
private Messenger getMessenger() { private Messenger getMessenger() {
try { try {
@@ -676,4 +640,18 @@ public final class NsdManager {
throw e.rethrowFromSystemServer(); throw e.rethrowFromSystemServer();
} }
} }
private static void checkListener(Object listener) {
checkNotNull(listener, "listener cannot be null");
}
private static void checkProtocol(int protocolType) {
checkArgument(protocolType == PROTOCOL_DNS_SD, "Unsupported protocol");
}
private static void checkServiceInfo(NsdServiceInfo serviceInfo) {
checkNotNull(serviceInfo, "NsdServiceInfo cannot be null");
checkStringNotEmpty(serviceInfo.getServiceName(),"Service name cannot be empty");
checkStringNotEmpty(serviceInfo.getServiceType(), "Service type cannot be empty");
}
} }

59
services/core/java/com/android/server/NsdService.java
View File

@@ -35,6 +35,7 @@ import android.provider.Settings;
import android.util.Base64; import android.util.Base64;
import android.util.Slog; import android.util.Slog;
import android.util.SparseArray; import android.util.SparseArray;
import android.util.SparseIntArray;
import java.io.FileDescriptor; import java.io.FileDescriptor;
import java.io.PrintWriter; import java.io.PrintWriter;
@@ -49,7 +50,6 @@ import com.android.internal.util.DumpUtils;
import com.android.internal.util.Protocol; import com.android.internal.util.Protocol;
import com.android.internal.util.State; import com.android.internal.util.State;
import com.android.internal.util.StateMachine; import com.android.internal.util.StateMachine;
import com.android.server.NativeDaemonConnector.Command;
/** /**
* Network Service Discovery Service handles remote service discovery operation requests by * Network Service Discovery Service handles remote service discovery operation requests by
@@ -162,7 +162,7 @@ public class NsdService extends INsdManager.Stub {
} }
//Last client //Last client
if (mClients.size() == 0) { if (mClients.size() == 0) {
stopMDnsDaemon(); mDaemon.stop();
} }
break; break;
case AsyncChannel.CMD_CHANNEL_FULL_CONNECTION: case AsyncChannel.CMD_CHANNEL_FULL_CONNECTION:
@@ -222,14 +222,14 @@ public class NsdService extends INsdManager.Stub {
public void enter() { public void enter() {
sendNsdStateChangeBroadcast(true); sendNsdStateChangeBroadcast(true);
if (mClients.size() > 0) { if (mClients.size() > 0) {
startMDnsDaemon(); mDaemon.start();
} }
} }
@Override @Override
public void exit() { public void exit() {
if (mClients.size() > 0) { if (mClients.size() > 0) {
stopMDnsDaemon(); mDaemon.stop();
} }
} }
@@ -248,8 +248,8 @@ public class NsdService extends INsdManager.Stub {
} }
private void removeRequestMap(int clientId, int globalId, ClientInfo clientInfo) { private void removeRequestMap(int clientId, int globalId, ClientInfo clientInfo) {
clientInfo.mClientIds.remove(clientId); clientInfo.mClientIds.delete(clientId);
clientInfo.mClientRequests.remove(clientId); clientInfo.mClientRequests.delete(clientId);
mIdToClientInfoMap.remove(globalId); mIdToClientInfoMap.remove(globalId);
} }
@@ -263,7 +263,7 @@ public class NsdService extends INsdManager.Stub {
//First client //First client
if (msg.arg1 == AsyncChannel.STATUS_SUCCESSFUL && if (msg.arg1 == AsyncChannel.STATUS_SUCCESSFUL &&
mClients.size() == 0) { mClients.size() == 0) {
startMDnsDaemon(); mDaemon.start();
} }
return NOT_HANDLED; return NOT_HANDLED;
case AsyncChannel.CMD_CHANNEL_DISCONNECTED: case AsyncChannel.CMD_CHANNEL_DISCONNECTED:
@@ -302,7 +302,7 @@ public class NsdService extends INsdManager.Stub {
clientInfo = mClients.get(msg.replyTo); clientInfo = mClients.get(msg.replyTo);
try { try {
id = clientInfo.mClientIds.get(msg.arg2).intValue(); id = clientInfo.mClientIds.get(msg.arg2);
} catch (NullPointerException e) { } catch (NullPointerException e) {
replyToMessage(msg, NsdManager.STOP_DISCOVERY_FAILED, replyToMessage(msg, NsdManager.STOP_DISCOVERY_FAILED,
NsdManager.FAILURE_INTERNAL_ERROR); NsdManager.FAILURE_INTERNAL_ERROR);
@@ -340,7 +340,7 @@ public class NsdService extends INsdManager.Stub {
if (DBG) Slog.d(TAG, "unregister service"); if (DBG) Slog.d(TAG, "unregister service");
clientInfo = mClients.get(msg.replyTo); clientInfo = mClients.get(msg.replyTo);
try { try {
id = clientInfo.mClientIds.get(msg.arg2).intValue(); id = clientInfo.mClientIds.get(msg.arg2);
} catch (NullPointerException e) { } catch (NullPointerException e) {
replyToMessage(msg, NsdManager.UNREGISTER_SERVICE_FAILED, replyToMessage(msg, NsdManager.UNREGISTER_SERVICE_FAILED,
NsdManager.FAILURE_INTERNAL_ERROR); NsdManager.FAILURE_INTERNAL_ERROR);
@@ -713,26 +713,13 @@ public class NsdService extends INsdManager.Stub {
return true; return true;
} }
public boolean execute(Command cmd) { public void start() {
if (DBG) { execute("start-service");
Slog.d(TAG, cmd.toString());
}
try {
mNativeConnector.execute(cmd);
} catch (NativeDaemonConnectorException e) {
Slog.e(TAG, "Failed to execute " + cmd, e);
return false;
}
return true;
}
} }
private boolean startMDnsDaemon() { public void stop() {
return mDaemon.execute("start-service"); execute("stop-service");
} }
private boolean stopMDnsDaemon() {
return mDaemon.execute("stop-service");
} }
private boolean registerService(int regId, NsdServiceInfo service) { private boolean registerService(int regId, NsdServiceInfo service) {
@@ -744,8 +731,7 @@ public class NsdService extends INsdManager.Stub {
int port = service.getPort(); int port = service.getPort();
byte[] textRecord = service.getTxtRecord(); byte[] textRecord = service.getTxtRecord();
String record = Base64.encodeToString(textRecord, Base64.DEFAULT).replace("\n", ""); String record = Base64.encodeToString(textRecord, Base64.DEFAULT).replace("\n", "");
Command cmd = new Command("mdnssd", "register", regId, name, type, port, record); return mDaemon.execute("register", regId, name, type, port, record);
return mDaemon.execute(cmd);
} }
private boolean unregisterService(int regId) { private boolean unregisterService(int regId) {
@@ -838,10 +824,10 @@ public class NsdService extends INsdManager.Stub {
private NsdServiceInfo mResolvedService; private NsdServiceInfo mResolvedService;
/* A map from client id to unique id sent to mDns */ /* A map from client id to unique id sent to mDns */
private final SparseArray<Integer> mClientIds = new SparseArray<>(); private final SparseIntArray mClientIds = new SparseIntArray();
/* A map from client id to the type of the request we had received */ /* A map from client id to the type of the request we had received */
private final SparseArray<Integer> mClientRequests = new SparseArray<>(); private final SparseIntArray mClientRequests = new SparseIntArray();
private ClientInfo(AsyncChannel c, Messenger m) { private ClientInfo(AsyncChannel c, Messenger m) {
mChannel = c; mChannel = c;
@@ -868,6 +854,7 @@ public class NsdService extends INsdManager.Stub {
// and send cancellations to the daemon. // and send cancellations to the daemon.
private void expungeAllRequests() { private void expungeAllRequests() {
int globalId, clientId, i; int globalId, clientId, i;
// TODO: to keep handler responsive, do not clean all requests for that client at once.
for (i = 0; i < mClientIds.size(); i++) { for (i = 0; i < mClientIds.size(); i++) {
clientId = mClientIds.keyAt(i); clientId = mClientIds.keyAt(i);
globalId = mClientIds.valueAt(i); globalId = mClientIds.valueAt(i);
@@ -895,15 +882,11 @@ public class NsdService extends INsdManager.Stub {
// mClientIds is a sparse array of listener id -> mDnsClient id. For a given mDnsClient id, // mClientIds is a sparse array of listener id -> mDnsClient id. For a given mDnsClient id,
// return the corresponding listener id. mDnsClient id is also called a global id. // return the corresponding listener id. mDnsClient id is also called a global id.
private int getClientId(final int globalId) { private int getClientId(final int globalId) {
// This doesn't use mClientIds.indexOfValue because indexOfValue uses == (not .equals) int idx = mClientIds.indexOfValue(globalId);
// while also coercing the int primitives to Integer objects. if (idx < 0) {
for (int i = 0, nSize = mClientIds.size(); i < nSize; i++) { return idx;
int mDnsId = mClientIds.valueAt(i);
if (globalId == mDnsId) {
return mClientIds.keyAt(i);
} }
} return mClientIds.keyAt(idx);
return -1;
} }
} }