LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[NS A41] Cut out a function to update NAI info

Browse Source 
Test: ConnectivityServiceTest
Change-Id: I6d92fb1699eb0acb1bcd7baa4a5d9d3e1c0dc728
This commit is contained in:
Chalard Jean
2019-12-04 13:32:31 +09:00
parent 47dad79bf6
commit 24344d7e72
1 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
services/core/java/com/android/server/ConnectivityService.java
View File

@@ -6636,6 +6636,14 @@ public class ConnectivityService extends IConnectivityManager.Stub
final NetworkAgentInfo newSatisfier = entry.getValue(); final NetworkAgentInfo newSatisfier = entry.getValue();
changes.addRequestReassignment(new NetworkReassignment.RequestReassignment( changes.addRequestReassignment(new NetworkReassignment.RequestReassignment(
nri, previousSatisfier, newSatisfier)); nri, previousSatisfier, newSatisfier));
updateSatisfiersForRematchRequest(nri, previousSatisfier, newSatisfier, now);
}
}
private void updateSatisfiersForRematchRequest(@NonNull final NetworkRequestInfo nri,
@Nullable final NetworkAgentInfo previousSatisfier,
@Nullable final NetworkAgentInfo newSatisfier,
final long now) {
if (newSatisfier != null) { if (newSatisfier != null) {
if (VDBG) log("rematch for " + newSatisfier.name()); if (VDBG) log("rematch for " + newSatisfier.name());
if (previousSatisfier != null) { if (previousSatisfier != null) {
@@ -6652,22 +6660,14 @@ public class ConnectivityService extends IConnectivityManager.Stub
Slog.wtf(TAG, "BUG: " + newSatisfier.name() + " already has " + nri.request); Slog.wtf(TAG, "BUG: " + newSatisfier.name() + " already has " + nri.request);
} }
} else { } else {
// If "newNetwork" is listed as satisfying "nri" but no longer satisfies "nri",
// mark it as no longer satisfying "nri". Because networks are processed by
// rematchAllNetworksAndRequests() in descending score order, "currentNetwork" will
// match "newNetwork" before this loop will encounter a "currentNetwork" with higher
// score than "newNetwork" and where "currentNetwork" no longer satisfies "nri".
// This means this code doesn't have to handle the case where "currentNetwork" no
// longer satisfies "nri" when "currentNetwork" does not equal "newNetwork".
if (DBG) { if (DBG) {
log("Network " + newNetwork.name() + " stopped satisfying" + log("Network " + previousSatisfier.name() + " stopped satisfying"
" request " + nri.request.requestId); + " request " + nri.request.requestId);
} }
newNetwork.removeRequest(nri.request.requestId); previousSatisfier.removeRequest(nri.request.requestId);
} }
nri.mSatisfier = newSatisfier; nri.mSatisfier = newSatisfier;
} }
}
/** /**
* Attempt to rematch all Networks with NetworkRequests. This may result in Networks * Attempt to rematch all Networks with NetworkRequests. This may result in Networks