Address remaining comments on aosp/1607893
Test: ConnectivityServiceTest Change-Id: Icf70b20624604bfade37804311a77ef6be564c09
This commit is contained in:
@@ -11402,7 +11402,6 @@ public class ConnectivityServiceTest {
|
||||
mSystemDefaultNetworkCallback.expectCallback(CallbackEntry.LOST, mCellNetworkAgent);
|
||||
mDefaultNetworkCallback.expectCallback(CallbackEntry.LOST, mCellNetworkAgent);
|
||||
mProfileDefaultNetworkCallback.assertNoCallback();
|
||||
waitForIdle();
|
||||
inOrder.verify(mMockNetd).networkDestroy(mCellNetworkAgent.getNetwork().netId);
|
||||
|
||||
mCellNetworkAgent = new TestNetworkAgentWrapper(TRANSPORT_CELLULAR);
|
||||
@@ -11421,7 +11420,6 @@ public class ConnectivityServiceTest {
|
||||
assertNoCallbacks(mSystemDefaultNetworkCallback, mDefaultNetworkCallback);
|
||||
inOrder.verify(mMockNetd).networkAddUidRanges(mCellNetworkAgent.getNetwork().netId,
|
||||
uidRangeFor(testHandle));
|
||||
waitForIdle();
|
||||
inOrder.verify(mMockNetd).networkDestroy(workAgent.getNetwork().netId);
|
||||
|
||||
mCellNetworkAgent.disconnect();
|
||||
@@ -11429,6 +11427,8 @@ public class ConnectivityServiceTest {
|
||||
mDefaultNetworkCallback.expectCallback(CallbackEntry.LOST, mCellNetworkAgent);
|
||||
mProfileDefaultNetworkCallback.expectCallback(CallbackEntry.LOST, mCellNetworkAgent);
|
||||
|
||||
// Waiting for the handler to be idle before checking for networkDestroy is necessary
|
||||
// here because ConnectivityService calls onLost before the network is fully torn down.
|
||||
waitForIdle();
|
||||
inOrder.verify(mMockNetd).networkDestroy(mCellNetworkAgent.getNetwork().netId);
|
||||
|
||||
@@ -11458,7 +11458,6 @@ public class ConnectivityServiceTest {
|
||||
workAgent2.disconnect();
|
||||
mProfileDefaultNetworkCallback.expectCallback(CallbackEntry.LOST, workAgent2);
|
||||
assertNoCallbacks(mSystemDefaultNetworkCallback, mDefaultNetworkCallback);
|
||||
waitForIdle();
|
||||
inOrder.verify(mMockNetd).networkDestroy(workAgent2.getNetwork().netId);
|
||||
|
||||
assertNoCallbacks(mSystemDefaultNetworkCallback, mDefaultNetworkCallback,
|
||||
|
||||
Reference in New Issue
Block a user