From 2d235fbe335274baaffe89a2a664d5bd92d289f1 Mon Sep 17 00:00:00 2001 From: Chalard Jean Date: Mon, 1 Mar 2021 22:12:56 +0900 Subject: [PATCH] Fix a bug where a request would not be refcounted This ends up crashing the system when the request is unregistered, because the ref counter finds the count associated with the relevant UID is zero. Test: FrameworksNetTests Test: TODO : this needs a new unit test Change-Id: I0ee0ce925a826d35d8fd58cefb8a870e98ce9add --- services/core/java/com/android/server/ConnectivityService.java | 1 + 1 file changed, 1 insertion(+) diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index 12b094eaee..2b6523a72e 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -5259,6 +5259,7 @@ public class ConnectivityService extends IConnectivityManager.Stub mPid = nri.mPid; mUid = nri.mUid; mPendingIntent = nri.mPendingIntent; + mNetworkRequestCounter.incrementCountOrThrow(mUid); mCallingAttributionTag = nri.mCallingAttributionTag; }