Merge "Remove return value of ipSecAddSecurityAssociation" am: 36acf01d58 am: 84aa41dae2 am: c554c2c1cb
am: 4ba38b60e2
Change-Id: I77f2e8be5a3ce9fe1c8c49b2530a8955abf5b0cc
This commit is contained in:
@@ -605,7 +605,6 @@ public class IpSecService extends IIpSecService.Stub {
|
||||
spis[direction] = mSpiRecords.get(c.getSpiResourceId(direction));
|
||||
int spi = spis[direction].getSpi();
|
||||
try {
|
||||
int result =
|
||||
getNetdInstance()
|
||||
.ipSecAddSecurityAssociation(
|
||||
resourceId,
|
||||
@@ -630,13 +629,9 @@ public class IpSecService extends IIpSecService.Stub {
|
||||
encapType,
|
||||
encapLocalPort,
|
||||
encapRemotePort);
|
||||
if (result != spi) {
|
||||
// TODO: cleanup the first SA if creation of second SA fails
|
||||
return new IpSecTransformResponse(
|
||||
IpSecManager.Status.SPI_UNAVAILABLE, INVALID_RESOURCE_ID);
|
||||
}
|
||||
} catch (ServiceSpecificException e) {
|
||||
// FIXME: get the error code and throw is at an IOException from Errno Exception
|
||||
return new IpSecTransformResponse(IpSecManager.Status.RESOURCE_UNAVAILABLE);
|
||||
}
|
||||
}
|
||||
// Both SAs were created successfully, time to construct a record and lock it away
|
||||
|
||||
Reference in New Issue
Block a user