From 451b1c86090304aaa47f782b14e0e2bb3552abee Mon Sep 17 00:00:00 2001 From: paulhu Date: Thu, 4 Apr 2019 00:07:40 +0800 Subject: [PATCH] Fix ConnectivityServiceTest fail. NetdService#getInstance() will get null object in WrappedConnectivityService constructor. Then pass this null INetd object to PermissionMonitor will case NPE in PermissionMonitor#sendPackagePermissionsToNetd() Bug: None Test: atest FrameworksNetTests Change-Id: Ia1c80f9600a19c4aaf3f3c1b497b355d96c49c8e --- .../com/android/server/connectivity/PermissionMonitor.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/connectivity/PermissionMonitor.java b/services/core/java/com/android/server/connectivity/PermissionMonitor.java index 31b96ca9e5..b9f1748be1 100644 --- a/services/core/java/com/android/server/connectivity/PermissionMonitor.java +++ b/services/core/java/com/android/server/connectivity/PermissionMonitor.java @@ -466,7 +466,10 @@ public class PermissionMonitor { */ @VisibleForTesting void sendPackagePermissionsToNetd(SparseIntArray netdPermissionsAppIds) { - + if (mNetd == null) { + Log.e(TAG, "Failed to get the netd service"); + return; + } ArrayList allPermissionAppIds = new ArrayList<>(); ArrayList internetPermissionAppIds = new ArrayList<>(); ArrayList updateStatsPermissionAppIds = new ArrayList<>();