LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory access violation in NetworkStack

Browse Source 
Fix memory access violation in com_android_networkstack_tethering_BpfUtils.cpp
caused by invalid format string in com_android_networkstack_tethering_BpfUtils_isEthernet.
If rv is not valid, jniThrowException will format a string using
"Unknown hardware address type %s on interface %s". However, rv is an int but here
"%s" is used in fmt string, thus causing access violation of memory.

Use "%d" instead of "%s" for int.

Bug: 188757793
Original-Change: https://android-review.googlesource.com/1715797
Merged-In: I9d8ec0708efd747e24b3b3ffed5336434d4f64a7
Change-Id: I9d8ec0708efd747e24b3b3ffed5336434d4f64a7
This commit is contained in:
Maciej Żenczykowski
2021-05-25 00:18:35 +00:00
committed by Nucca Chen
parent 58b943a701
commit 365ada7e04
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tethering/jni/com_android_networkstack_tethering_BpfUtils.cpp
View File

@@ -183,7 +183,7 @@ static jboolean com_android_networkstack_tethering_BpfUtils_isEthernet(JNIEnv* e
return false;
default:
jniThrowExceptionFmt(env, "java/io/IOException",
"Unknown hardware address type %s on interface %s", rv,
"Unknown hardware address type %d on interface %s", rv,
interface.c_str());
return false;
}