Add @Nullable to Object#equals()

This is a partial cherry-pick of change:
I5eedb571c9d78862115dfdc5dae1cf2a35343580

for connectivity classes.

Bug: 170883422
Test: m
Merged-In: I5eedb571c9d78862115dfdc5dae1cf2a35343580
Change-Id: I7dc661863b73f4198ddb4f3a1566583d0f07db3c
This commit is contained in:
Roman Kalukiewicz
2020-10-14 15:59:06 -07:00
committed by Remi NGUYEN VAN
parent 1b2443d1c5
commit 384a8c63f2
11 changed files with 15 additions and 12 deletions

View File

@@ -18,6 +18,7 @@ package android.net;
import static android.os.UserHandle.PER_USER_RANGE; import static android.os.UserHandle.PER_USER_RANGE;
import android.annotation.Nullable;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
@@ -81,7 +82,7 @@ public final class UidRange implements Parcelable {
} }
@Override @Override
public boolean equals(Object o) { public boolean equals(@Nullable Object o) {
if (this == o) { if (this == o) {
return true; return true;
} }

View File

@@ -276,7 +276,7 @@ public final class CaptivePortalData implements Parcelable {
} }
@Override @Override
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (!(obj instanceof CaptivePortalData)) return false; if (!(obj instanceof CaptivePortalData)) return false;
final CaptivePortalData other = (CaptivePortalData) obj; final CaptivePortalData other = (CaptivePortalData) obj;
return mRefreshTimeMillis == other.mRefreshTimeMillis return mRefreshTimeMillis == other.mRefreshTimeMillis

View File

@@ -167,7 +167,7 @@ public final class IpConfiguration implements Parcelable {
} }
@Override @Override
public boolean equals(Object o) { public boolean equals(@Nullable Object o) {
if (o == this) { if (o == this) {
return true; return true;
} }

View File

@@ -18,6 +18,7 @@ package android.net;
import android.annotation.IntRange; import android.annotation.IntRange;
import android.annotation.NonNull; import android.annotation.NonNull;
import android.annotation.Nullable;
import android.annotation.SystemApi; import android.annotation.SystemApi;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
@@ -124,7 +125,7 @@ public final class IpPrefix implements Parcelable {
* @return {@code true} if both objects are equal, {@code false} otherwise. * @return {@code true} if both objects are equal, {@code false} otherwise.
*/ */
@Override @Override
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (!(obj instanceof IpPrefix)) { if (!(obj instanceof IpPrefix)) {
return false; return false;
} }

View File

@@ -349,7 +349,7 @@ public class LinkAddress implements Parcelable {
* @return {@code true} if both objects are equal, {@code false} otherwise. * @return {@code true} if both objects are equal, {@code false} otherwise.
*/ */
@Override @Override
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (!(obj instanceof LinkAddress)) { if (!(obj instanceof LinkAddress)) {
return false; return false;
} }

View File

@@ -1613,7 +1613,7 @@ public final class LinkProperties implements Parcelable {
* @return {@code true} if both objects are equal, {@code false} otherwise. * @return {@code true} if both objects are equal, {@code false} otherwise.
*/ */
@Override @Override
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (this == obj) return true; if (this == obj) return true;
if (!(obj instanceof LinkProperties)) return false; if (!(obj instanceof LinkProperties)) return false;

View File

@@ -161,7 +161,7 @@ public final class MacAddress implements Parcelable {
} }
@Override @Override
public boolean equals(Object o) { public boolean equals(@Nullable Object o) {
return (o instanceof MacAddress) && ((MacAddress) o).mAddr == mAddr; return (o instanceof MacAddress) && ((MacAddress) o).mAddr == mAddr;
} }

View File

@@ -17,6 +17,7 @@
package android.net; package android.net;
import android.annotation.NonNull; import android.annotation.NonNull;
import android.annotation.Nullable;
import android.annotation.SystemApi; import android.annotation.SystemApi;
import android.compat.annotation.UnsupportedAppUsage; import android.compat.annotation.UnsupportedAppUsage;
import android.os.Build; import android.os.Build;
@@ -510,7 +511,7 @@ public class Network implements Parcelable {
}; };
@Override @Override
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (!(obj instanceof Network)) return false; if (!(obj instanceof Network)) return false;
Network other = (Network)obj; Network other = (Network)obj;
return this.netId == other.netId; return this.netId == other.netId;

View File

@@ -567,7 +567,7 @@ public class NetworkRequest implements Parcelable {
proto.end(token); proto.end(token);
} }
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (obj instanceof NetworkRequest == false) return false; if (obj instanceof NetworkRequest == false) return false;
NetworkRequest that = (NetworkRequest)obj; NetworkRequest that = (NetworkRequest)obj;
return (that.legacyType == this.legacyType && return (that.legacyType == this.legacyType &&

View File

@@ -275,7 +275,7 @@ public class ProxyInfo implements Parcelable {
} }
@Override @Override
public boolean equals(Object o) { public boolean equals(@Nullable Object o) {
if (!(o instanceof ProxyInfo)) return false; if (!(o instanceof ProxyInfo)) return false;
ProxyInfo p = (ProxyInfo)o; ProxyInfo p = (ProxyInfo)o;
// If PAC URL is present in either then they must be equal. // If PAC URL is present in either then they must be equal.

View File

@@ -534,7 +534,7 @@ public final class RouteInfo implements Parcelable {
* Compares this RouteInfo object against the specified object and indicates if they are equal. * Compares this RouteInfo object against the specified object and indicates if they are equal.
* @return {@code true} if the objects are equal, {@code false} otherwise. * @return {@code true} if the objects are equal, {@code false} otherwise.
*/ */
public boolean equals(Object obj) { public boolean equals(@Nullable Object obj) {
if (this == obj) return true; if (this == obj) return true;
if (!(obj instanceof RouteInfo)) return false; if (!(obj instanceof RouteInfo)) return false;
@@ -570,7 +570,7 @@ public final class RouteInfo implements Parcelable {
} }
@Override @Override
public boolean equals(Object o) { public boolean equals(@Nullable Object o) {
if (!(o instanceof RouteKey)) { if (!(o instanceof RouteKey)) {
return false; return false;
} }