Merge "Use UID as requestID"
am: a2f1eb6cf3
Change-Id: Icef3693f5911c8f69076e0990392e28c693cbc22
This commit is contained in:
@@ -41,9 +41,9 @@ import android.net.Network;
|
|||||||
import android.net.NetworkUtils;
|
import android.net.NetworkUtils;
|
||||||
import android.os.Binder;
|
import android.os.Binder;
|
||||||
import android.os.ParcelFileDescriptor;
|
import android.os.ParcelFileDescriptor;
|
||||||
import android.test.mock.MockContext;
|
|
||||||
import android.support.test.filters.SmallTest;
|
import android.support.test.filters.SmallTest;
|
||||||
import android.system.Os;
|
import android.system.Os;
|
||||||
|
import android.test.mock.MockContext;
|
||||||
|
|
||||||
import java.net.Socket;
|
import java.net.Socket;
|
||||||
import java.util.Arrays;
|
import java.util.Arrays;
|
||||||
@@ -121,6 +121,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
IpSecService.IpSecServiceConfiguration mMockIpSecSrvConfig;
|
IpSecService.IpSecServiceConfiguration mMockIpSecSrvConfig;
|
||||||
IpSecService mIpSecService;
|
IpSecService mIpSecService;
|
||||||
Network fakeNetwork = new Network(0xAB);
|
Network fakeNetwork = new Network(0xAB);
|
||||||
|
int mUid = Os.getuid();
|
||||||
|
|
||||||
private static final IpSecAlgorithm AUTH_ALGO =
|
private static final IpSecAlgorithm AUTH_ALGO =
|
||||||
new IpSecAlgorithm(IpSecAlgorithm.AUTH_HMAC_SHA256, AUTH_KEY, AUTH_KEY.length * 4);
|
new IpSecAlgorithm(IpSecAlgorithm.AUTH_HMAC_SHA256, AUTH_KEY, AUTH_KEY.length * 4);
|
||||||
@@ -181,7 +182,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecDeleteSecurityAssociation(
|
.ipSecDeleteSecurityAssociation(
|
||||||
eq(spiResp.resourceId),
|
eq(mUid),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
eq(TEST_SPI),
|
eq(TEST_SPI),
|
||||||
@@ -189,8 +190,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
anyInt());
|
anyInt());
|
||||||
|
|
||||||
// Verify quota and RefcountedResource objects cleaned up
|
// Verify quota and RefcountedResource objects cleaned up
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
assertEquals(0, userRecord.mSpiQuotaTracker.mCurrent);
|
assertEquals(0, userRecord.mSpiQuotaTracker.mCurrent);
|
||||||
try {
|
try {
|
||||||
userRecord.mSpiRecords.getRefcountedResourceOrThrow(spiResp.resourceId);
|
userRecord.mSpiRecords.getRefcountedResourceOrThrow(spiResp.resourceId);
|
||||||
@@ -209,8 +209,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
mIpSecService.allocateSecurityParameterIndex(
|
mIpSecService.allocateSecurityParameterIndex(
|
||||||
mDestinationAddr, TEST_SPI, new Binder());
|
mDestinationAddr, TEST_SPI, new Binder());
|
||||||
|
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
IpSecService.RefcountedResource refcountedRecord =
|
IpSecService.RefcountedResource refcountedRecord =
|
||||||
userRecord.mSpiRecords.getRefcountedResourceOrThrow(spiResp.resourceId);
|
userRecord.mSpiRecords.getRefcountedResourceOrThrow(spiResp.resourceId);
|
||||||
|
|
||||||
@@ -218,7 +217,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecDeleteSecurityAssociation(
|
.ipSecDeleteSecurityAssociation(
|
||||||
eq(spiResp.resourceId),
|
eq(mUid),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
eq(TEST_SPI),
|
eq(TEST_SPI),
|
||||||
@@ -270,7 +269,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecAddSecurityAssociation(
|
.ipSecAddSecurityAssociation(
|
||||||
eq(createTransformResp.resourceId),
|
eq(mUid),
|
||||||
anyInt(),
|
anyInt(),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
@@ -305,7 +304,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecAddSecurityAssociation(
|
.ipSecAddSecurityAssociation(
|
||||||
eq(createTransformResp.resourceId),
|
eq(mUid),
|
||||||
anyInt(),
|
anyInt(),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
@@ -361,13 +360,12 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
IpSecTransformResponse createTransformResp =
|
IpSecTransformResponse createTransformResp =
|
||||||
mIpSecService.createTransform(ipSecConfig, new Binder(), "blessedPackage");
|
mIpSecService.createTransform(ipSecConfig, new Binder(), "blessedPackage");
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
assertEquals(1, userRecord.mSpiQuotaTracker.mCurrent);
|
assertEquals(1, userRecord.mSpiQuotaTracker.mCurrent);
|
||||||
mIpSecService.releaseSecurityParameterIndex(ipSecConfig.getSpiResourceId());
|
mIpSecService.releaseSecurityParameterIndex(ipSecConfig.getSpiResourceId());
|
||||||
verify(mMockNetd, times(0))
|
verify(mMockNetd, times(0))
|
||||||
.ipSecDeleteSecurityAssociation(
|
.ipSecDeleteSecurityAssociation(
|
||||||
eq(createTransformResp.resourceId),
|
eq(mUid),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
eq(TEST_SPI),
|
eq(TEST_SPI),
|
||||||
@@ -389,7 +387,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd, times(1))
|
verify(mMockNetd, times(1))
|
||||||
.ipSecDeleteSecurityAssociation(
|
.ipSecDeleteSecurityAssociation(
|
||||||
eq(createTransformResp.resourceId),
|
eq(mUid),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
eq(TEST_SPI),
|
eq(TEST_SPI),
|
||||||
@@ -397,8 +395,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
anyInt());
|
anyInt());
|
||||||
|
|
||||||
// Verify quota and RefcountedResource objects cleaned up
|
// Verify quota and RefcountedResource objects cleaned up
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
assertEquals(0, userRecord.mTransformQuotaTracker.mCurrent);
|
assertEquals(0, userRecord.mTransformQuotaTracker.mCurrent);
|
||||||
assertEquals(1, userRecord.mSpiQuotaTracker.mCurrent);
|
assertEquals(1, userRecord.mSpiQuotaTracker.mCurrent);
|
||||||
|
|
||||||
@@ -433,8 +430,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
IpSecTransformResponse createTransformResp =
|
IpSecTransformResponse createTransformResp =
|
||||||
mIpSecService.createTransform(ipSecConfig, new Binder(), "blessedPackage");
|
mIpSecService.createTransform(ipSecConfig, new Binder(), "blessedPackage");
|
||||||
|
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
IpSecService.RefcountedResource refcountedRecord =
|
IpSecService.RefcountedResource refcountedRecord =
|
||||||
userRecord.mTransformRecords.getRefcountedResourceOrThrow(
|
userRecord.mTransformRecords.getRefcountedResourceOrThrow(
|
||||||
createTransformResp.resourceId);
|
createTransformResp.resourceId);
|
||||||
@@ -443,7 +439,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
|
|
||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecDeleteSecurityAssociation(
|
.ipSecDeleteSecurityAssociation(
|
||||||
eq(createTransformResp.resourceId),
|
eq(mUid),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
eq(TEST_SPI),
|
eq(TEST_SPI),
|
||||||
@@ -477,7 +473,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
verify(mMockNetd)
|
verify(mMockNetd)
|
||||||
.ipSecApplyTransportModeTransform(
|
.ipSecApplyTransportModeTransform(
|
||||||
eq(pfd.getFileDescriptor()),
|
eq(pfd.getFileDescriptor()),
|
||||||
eq(resourceId),
|
eq(mUid),
|
||||||
eq(IpSecManager.DIRECTION_OUT),
|
eq(IpSecManager.DIRECTION_OUT),
|
||||||
anyString(),
|
anyString(),
|
||||||
anyString(),
|
anyString(),
|
||||||
@@ -509,8 +505,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
||||||
|
|
||||||
// Check that we have stored the tracking object, and retrieve it
|
// Check that we have stored the tracking object, and retrieve it
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
IpSecService.RefcountedResource refcountedRecord =
|
IpSecService.RefcountedResource refcountedRecord =
|
||||||
userRecord.mTunnelInterfaceRecords.getRefcountedResourceOrThrow(
|
userRecord.mTunnelInterfaceRecords.getRefcountedResourceOrThrow(
|
||||||
createTunnelResp.resourceId);
|
createTunnelResp.resourceId);
|
||||||
@@ -530,8 +525,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
IpSecTunnelInterfaceResponse createTunnelResp =
|
IpSecTunnelInterfaceResponse createTunnelResp =
|
||||||
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
||||||
|
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
|
|
||||||
mIpSecService.deleteTunnelInterface(createTunnelResp.resourceId, "blessedPackage");
|
mIpSecService.deleteTunnelInterface(createTunnelResp.resourceId, "blessedPackage");
|
||||||
|
|
||||||
@@ -551,8 +545,7 @@ public class IpSecServiceParameterizedTest {
|
|||||||
IpSecTunnelInterfaceResponse createTunnelResp =
|
IpSecTunnelInterfaceResponse createTunnelResp =
|
||||||
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
createAndValidateTunnel(mSourceAddr, mDestinationAddr, "blessedPackage");
|
||||||
|
|
||||||
IpSecService.UserRecord userRecord =
|
IpSecService.UserRecord userRecord = mIpSecService.mUserResourceTracker.getUserRecord(mUid);
|
||||||
mIpSecService.mUserResourceTracker.getUserRecord(Os.getuid());
|
|
||||||
IpSecService.RefcountedResource refcountedRecord =
|
IpSecService.RefcountedResource refcountedRecord =
|
||||||
userRecord.mTunnelInterfaceRecords.getRefcountedResourceOrThrow(
|
userRecord.mTunnelInterfaceRecords.getRefcountedResourceOrThrow(
|
||||||
createTunnelResp.resourceId);
|
createTunnelResp.resourceId);
|
||||||
|
|||||||
Reference in New Issue
Block a user