LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "RateLimitTest: temporarily dump ConnectivityThread if setUp fails"

Browse Source 
This reverts commit cbe1755826.

Reason for revert: we found the culprit for the flakiness and b/272147742 is fixed.

Change-Id: I672c42bb57184393588666b6196f3a316f8c99c7
This commit is contained in:
Patrick Rohr
2023-09-27 16:35:05 +00:00
committed by Maciej Żenczykowski
parent 6aec2583cd
commit 479dbbd906
1 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/cts/net/src/android/net/cts/RateLimitTest.java
View File

@@ -36,7 +36,6 @@ import android.content.Context;
import android.icu.text.MessageFormat; import android.icu.text.MessageFormat;
import android.net.ConnectivityManager; import android.net.ConnectivityManager;
import android.net.ConnectivitySettingsManager; import android.net.ConnectivitySettingsManager;
import android.net.ConnectivityThread;
import android.net.InetAddresses; import android.net.InetAddresses;
import android.net.IpPrefix; import android.net.IpPrefix;
import android.net.LinkAddress; import android.net.LinkAddress;
@@ -190,19 +189,7 @@ public class RateLimitTest {
// whatever happens, don't leave the device in rate limited state. // whatever happens, don't leave the device in rate limited state.
ConnectivitySettingsManager.setIngressRateLimitInBytesPerSecond(mContext, -1); ConnectivitySettingsManager.setIngressRateLimitInBytesPerSecond(mContext, -1);
} }
if (mSocket == null) { if (mSocket != null) mSocket.close();
// HACK(b/272147742): dump ConnectivityThread if test initialization failed.
final StackTraceElement[] elements = ConnectivityThread.get().getStackTrace();
final StringBuilder sb = new StringBuilder();
// Skip first element as it includes the invocation of getStackTrace()
for (int i = 1; i < elements.length; i++) {
sb.append(elements[i]);
sb.append("\n");
}
Log.e(TAG, sb.toString());
} else {
mSocket.close();
}
if (mNetworkAgent != null) mNetworkAgent.unregister(); if (mNetworkAgent != null) mNetworkAgent.unregister();
if (mTunInterface != null) mTunInterface.getFileDescriptor().close(); if (mTunInterface != null) mTunInterface.getFileDescriptor().close();
if (mCm != null) mCm.unregisterNetworkCallback(mNetworkCallback); if (mCm != null) mCm.unregisterNetworkCallback(mNetworkCallback);