From 582770ce6859104ae0e58be80cfd560307aee60b Mon Sep 17 00:00:00 2001 From: Remi NGUYEN VAN Date: Mon, 28 Jun 2021 06:58:47 +0000 Subject: [PATCH] Fix flakes in tests running after testIsPrivateDnsBroken The test would not reconnect wifi after restoring the private DNS setting, so validation would not be triggered, and it would remain identified as having broken private DNS. Reconnect wifi after the test to avoid affecting subsequent tests. Change-Id: Id9beba94e0fed85bd26c0509ad61369be794f3c3 Test: atest android.net.cts.ConnectivityManagerTest Bug: 182296835 --- tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java index 24ecf7dea5..7bc0ec0a02 100644 --- a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java +++ b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java @@ -736,6 +736,8 @@ public class ConnectivityManagerTest { .isPrivateDnsBroken()) && networkForPrivateDns.equals(entry.getNetwork())); } finally { mCtsNetUtils.restorePrivateDnsSetting(); + // Toggle wifi to make sure it is re-validated + reconnectWifi(); } }