Remove usage for deprecated ro.radio.noril
The ro.radio.noril system properties is not used anymore. Tests that require to check if device supports wifi but not telephony should verify it via PackageManager.hasSystemFeature(). Also remove the systemProperties mocking since the only need for the mocking is removed. Bug: 242647857 Test: atest FrameworksNetTests CtsNetTestCases Change-Id: Ie34e87394458e64a9363678a863d6d977834958f
This commit is contained in:
@@ -165,7 +165,6 @@ import android.os.MessageQueue;
|
|||||||
import android.os.Process;
|
import android.os.Process;
|
||||||
import android.os.ServiceManager;
|
import android.os.ServiceManager;
|
||||||
import android.os.SystemClock;
|
import android.os.SystemClock;
|
||||||
import android.os.SystemProperties;
|
|
||||||
import android.os.UserHandle;
|
import android.os.UserHandle;
|
||||||
import android.os.VintfRuntimeInfo;
|
import android.os.VintfRuntimeInfo;
|
||||||
import android.platform.test.annotations.AppModeFull;
|
import android.platform.test.annotations.AppModeFull;
|
||||||
@@ -353,7 +352,8 @@ public class ConnectivityManagerTest {
|
|||||||
// Get com.android.internal.R.array.networkAttributes
|
// Get com.android.internal.R.array.networkAttributes
|
||||||
int resId = mContext.getResources().getIdentifier("networkAttributes", "array", "android");
|
int resId = mContext.getResources().getIdentifier("networkAttributes", "array", "android");
|
||||||
String[] naStrings = mContext.getResources().getStringArray(resId);
|
String[] naStrings = mContext.getResources().getStringArray(resId);
|
||||||
boolean wifiOnly = SystemProperties.getBoolean("ro.radio.noril", false);
|
boolean wifiOnly = mPackageManager.hasSystemFeature(FEATURE_WIFI)
|
||||||
|
&& !mPackageManager.hasSystemFeature(FEATURE_TELEPHONY);
|
||||||
for (String naString : naStrings) {
|
for (String naString : naStrings) {
|
||||||
try {
|
try {
|
||||||
final String[] splitConfig = naString.split(",");
|
final String[] splitConfig = naString.split(",");
|
||||||
|
|||||||
@@ -365,7 +365,6 @@ import com.android.server.ConnectivityServiceTest.ConnectivityServiceDependencie
|
|||||||
import com.android.server.connectivity.CarrierPrivilegeAuthenticator;
|
import com.android.server.connectivity.CarrierPrivilegeAuthenticator;
|
||||||
import com.android.server.connectivity.ClatCoordinator;
|
import com.android.server.connectivity.ClatCoordinator;
|
||||||
import com.android.server.connectivity.ConnectivityFlags;
|
import com.android.server.connectivity.ConnectivityFlags;
|
||||||
import com.android.server.connectivity.MockableSystemProperties;
|
|
||||||
import com.android.server.connectivity.Nat464Xlat;
|
import com.android.server.connectivity.Nat464Xlat;
|
||||||
import com.android.server.connectivity.NetworkAgentInfo;
|
import com.android.server.connectivity.NetworkAgentInfo;
|
||||||
import com.android.server.connectivity.NetworkNotificationManager.NotificationType;
|
import com.android.server.connectivity.NetworkNotificationManager.NotificationType;
|
||||||
@@ -1845,20 +1844,11 @@ public class ConnectivityServiceTest {
|
|||||||
|
|
||||||
class ConnectivityServiceDependencies extends ConnectivityService.Dependencies {
|
class ConnectivityServiceDependencies extends ConnectivityService.Dependencies {
|
||||||
final ConnectivityResources mConnRes;
|
final ConnectivityResources mConnRes;
|
||||||
@Mock final MockableSystemProperties mSystemProperties;
|
|
||||||
|
|
||||||
ConnectivityServiceDependencies(final Context mockResContext) {
|
ConnectivityServiceDependencies(final Context mockResContext) {
|
||||||
mSystemProperties = mock(MockableSystemProperties.class);
|
|
||||||
doReturn(false).when(mSystemProperties).getBoolean("ro.radio.noril", false);
|
|
||||||
|
|
||||||
mConnRes = new ConnectivityResources(mockResContext);
|
mConnRes = new ConnectivityResources(mockResContext);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
public MockableSystemProperties getSystemProperties() {
|
|
||||||
return mSystemProperties;
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public HandlerThread makeHandlerThread() {
|
public HandlerThread makeHandlerThread() {
|
||||||
return mCsHandlerThread;
|
return mCsHandlerThread;
|
||||||
|
|||||||
Reference in New Issue
Block a user