diff --git a/netd/BpfHandlerTest.cpp b/netd/BpfHandlerTest.cpp index cd6b565653..77f1a44d46 100644 --- a/netd/BpfHandlerTest.cpp +++ b/netd/BpfHandlerTest.cpp @@ -71,23 +71,19 @@ class BpfHandlerTest : public ::testing::Test { createMap(BPF_MAP_TYPE_HASH, sizeof(uint32_t), sizeof(uint8_t), TEST_MAP_SIZE, 0)); ASSERT_VALID(mFakeUidPermissionMap); - mBh.mCookieTagMap.reset(dupFd(mFakeCookieTagMap.getMap())); + mBh.mCookieTagMap = mFakeCookieTagMap; ASSERT_VALID(mBh.mCookieTagMap); - mBh.mStatsMapA.reset(dupFd(mFakeStatsMapA.getMap())); + mBh.mStatsMapA = mFakeStatsMapA; ASSERT_VALID(mBh.mStatsMapA); - mBh.mConfigurationMap.reset(dupFd(mFakeConfigurationMap.getMap())); + mBh.mConfigurationMap = mFakeConfigurationMap; ASSERT_VALID(mBh.mConfigurationMap); // Always write to stats map A by default. ASSERT_RESULT_OK(mBh.mConfigurationMap.writeValue(CURRENT_STATS_MAP_CONFIGURATION_KEY, SELECT_MAP_A, BPF_ANY)); - mBh.mUidPermissionMap.reset(dupFd(mFakeUidPermissionMap.getMap())); + mBh.mUidPermissionMap = mFakeUidPermissionMap; ASSERT_VALID(mBh.mUidPermissionMap); } - int dupFd(const android::base::unique_fd& mapFd) { - return fcntl(mapFd.get(), F_DUPFD_CLOEXEC, 0); - } - int setUpSocketAndTag(int protocol, uint64_t* cookie, uint32_t tag, uid_t uid, uid_t realUid) { int sock = socket(protocol, SOCK_STREAM | SOCK_CLOEXEC, 0); diff --git a/service/native/TrafficControllerTest.cpp b/service/native/TrafficControllerTest.cpp index 3f13532ead..55912f4171 100644 --- a/service/native/TrafficControllerTest.cpp +++ b/service/native/TrafficControllerTest.cpp @@ -96,29 +96,25 @@ class TrafficControllerTest : public ::testing::Test { createMap(BPF_MAP_TYPE_HASH, sizeof(uint32_t), sizeof(uint8_t), TEST_MAP_SIZE, 0)); ASSERT_VALID(mFakeUidPermissionMap); - mTc.mCookieTagMap.reset(dupFd(mFakeCookieTagMap.getMap())); + mTc.mCookieTagMap = mFakeCookieTagMap; ASSERT_VALID(mTc.mCookieTagMap); - mTc.mAppUidStatsMap.reset(dupFd(mFakeAppUidStatsMap.getMap())); + mTc.mAppUidStatsMap = mFakeAppUidStatsMap; ASSERT_VALID(mTc.mAppUidStatsMap); - mTc.mStatsMapA.reset(dupFd(mFakeStatsMapA.getMap())); + mTc.mStatsMapA = mFakeStatsMapA; ASSERT_VALID(mTc.mStatsMapA); - mTc.mConfigurationMap.reset(dupFd(mFakeConfigurationMap.getMap())); + mTc.mConfigurationMap = mFakeConfigurationMap; ASSERT_VALID(mTc.mConfigurationMap); // Always write to stats map A by default. ASSERT_RESULT_OK(mTc.mConfigurationMap.writeValue(CURRENT_STATS_MAP_CONFIGURATION_KEY, SELECT_MAP_A, BPF_ANY)); - mTc.mUidOwnerMap.reset(dupFd(mFakeUidOwnerMap.getMap())); + mTc.mUidOwnerMap = mFakeUidOwnerMap; ASSERT_VALID(mTc.mUidOwnerMap); - mTc.mUidPermissionMap.reset(dupFd(mFakeUidPermissionMap.getMap())); + mTc.mUidPermissionMap = mFakeUidPermissionMap; ASSERT_VALID(mTc.mUidPermissionMap); mTc.mPrivilegedUser.clear(); } - int dupFd(const android::base::unique_fd& mapFd) { - return fcntl(mapFd.get(), F_DUPFD_CLOEXEC, 0); - } - void populateFakeStats(uint64_t cookie, uint32_t uid, uint32_t tag, StatsKey* key) { UidTagValue cookieMapkey = {.uid = (uint32_t)uid, .tag = tag}; EXPECT_RESULT_OK(mFakeCookieTagMap.writeValue(cookie, cookieMapkey, BPF_ANY));