LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused mDnsOverridden

Browse Source 
mDnsOverridden is no longer used now that VPNs do not override the
default DNS settings.

Change-Id: I69495b9a6de7d60628813f357d3dbdf548695ada
This commit is contained in:
Chad Brubaker
2013-07-23 17:44:41 -07:00
parent 73652d07b8
commit 5fdc14656c
1 changed files with 5 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
services/java/com/android/server/ConnectivityService.java
View File

@@ -235,7 +235,6 @@ public class ConnectivityService extends IConnectivityManager.Stub {
private Object mDnsLock = new Object(); private Object mDnsLock = new Object();
private int mNumDnsEntries; private int mNumDnsEntries;
private boolean mDnsOverridden = false;
private boolean mTestMode; private boolean mTestMode;
private static ConnectivityService sServiceInstance; private static ConnectivityService sServiceInstance;
@@ -306,29 +305,23 @@ public class ConnectivityService extends IConnectivityManager.Stub {
*/ */
private static final int EVENT_SET_DEPENDENCY_MET = 10; private static final int EVENT_SET_DEPENDENCY_MET = 10;
/**
* used internally to restore DNS properties back to the
* default network
*/
private static final int EVENT_RESTORE_DNS = 11;
/** /**
* used internally to send a sticky broadcast delayed. * used internally to send a sticky broadcast delayed.
*/ */
private static final int EVENT_SEND_STICKY_BROADCAST_INTENT = 12; private static final int EVENT_SEND_STICKY_BROADCAST_INTENT = 11;
/** /**
* Used internally to * Used internally to
* {@link NetworkStateTracker#setPolicyDataEnable(boolean)}. * {@link NetworkStateTracker#setPolicyDataEnable(boolean)}.
*/ */
private static final int EVENT_SET_POLICY_DATA_ENABLE = 13; private static final int EVENT_SET_POLICY_DATA_ENABLE = 12;
private static final int EVENT_VPN_STATE_CHANGED = 14; private static final int EVENT_VPN_STATE_CHANGED = 13;
/** /**
* Used internally to disable fail fast of mobile data * Used internally to disable fail fast of mobile data
*/ */
private static final int EVENT_ENABLE_FAIL_FAST_MOBILE_DATA = 15; private static final int EVENT_ENABLE_FAIL_FAST_MOBILE_DATA = 14;
/** Handler used for internal events. */ /** Handler used for internal events. */
private InternalHandler mHandler; private InternalHandler mHandler;
@@ -2628,10 +2621,8 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (mNetConfigs[netType].isDefault()) { if (mNetConfigs[netType].isDefault()) {
String network = nt.getNetworkInfo().getTypeName(); String network = nt.getNetworkInfo().getTypeName();
synchronized (mDnsLock) { synchronized (mDnsLock) {
if (!mDnsOverridden) {
updateDnsLocked(network, p.getInterfaceName(), dnses, p.getDomains(), true); updateDnsLocked(network, p.getInterfaceName(), dnses, p.getDomains(), true);
} }
}
} else { } else {
try { try {
mNetd.setDnsServersForInterface(p.getInterfaceName(), mNetd.setDnsServersForInterface(p.getInterfaceName(),
@@ -2883,13 +2874,6 @@ public class ConnectivityService extends IConnectivityManager.Stub {
handleSetDependencyMet(msg.arg2, met); handleSetDependencyMet(msg.arg2, met);
break; break;
} }
case EVENT_RESTORE_DNS:
{
if (mActiveDefaultNetwork != -1) {
handleDnsConfigurationChange(mActiveDefaultNetwork);
}
break;
}
case EVENT_SEND_STICKY_BROADCAST_INTENT: case EVENT_SEND_STICKY_BROADCAST_INTENT:
{ {
Intent intent = (Intent)msg.obj; Intent intent = (Intent)msg.obj;
@@ -3515,12 +3499,6 @@ public class ConnectivityService extends IConnectivityManager.Stub {
} }
public void restore() { public void restore() {
synchronized (mDnsLock) {
if (mDnsOverridden) {
mDnsOverridden = false;
mHandler.sendEmptyMessage(EVENT_RESTORE_DNS);
}
}
synchronized (mProxyLock) { synchronized (mProxyLock) {
mDefaultProxyDisabled = false; mDefaultProxyDisabled = false;
if (mGlobalProxy == null && mDefaultProxy != null) { if (mGlobalProxy == null && mDefaultProxy != null) {