From b91d44a64a4b04cf107729cc049839f2f4c5bd31 Mon Sep 17 00:00:00 2001 From: Treehugger Robot Date: Mon, 28 Jun 2021 10:37:05 +0000 Subject: [PATCH] Fix flakes in tests running after testIsPrivateDnsBroken The test would not reconnect wifi after restoring the private DNS setting, so validation would not be triggered, and it would remain identified as having broken private DNS. Reconnect wifi after the test to avoid affecting subsequent tests. Original-Change: https://android-review.googlesource.com/1749560 Merged-In: Id9beba94e0fed85bd26c0509ad61369be794f3c3 Change-Id: Id9beba94e0fed85bd26c0509ad61369be794f3c3 Test: atest android.net.cts.ConnectivityManagerTest Bug: 182296835 --- tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java index ed477a2ee8..ca8d9e6380 100644 --- a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java +++ b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java @@ -737,6 +737,8 @@ public class ConnectivityManagerTest { .isPrivateDnsBroken()) && networkForPrivateDns.equals(entry.getNetwork())); } finally { mCtsNetUtils.restorePrivateDnsSetting(); + // Toggle wifi to make sure it is re-validated + reconnectWifi(); } }