From 1b35e829c6de648230560196f043425d18f6b42e Mon Sep 17 00:00:00 2001 From: paulhu Date: Fri, 8 Apr 2022 14:48:41 +0800 Subject: [PATCH] Remove InterruptedException from NsdService#create - NsdService isn't using NativeDaemonConnector to connect to mdnsresponder after aosp/2049246, so NsdService#create won't throw InterruptedException. - Also no need to catch InterruptedException in ConnectivityServiceInitializer. Bug: 209894875 Test: atest FrameworksNetTests CtsNetTestCases Merged-In: I1d0b973f9dac0f1d4f9d4d03faef66f05edde3fc Change-Id: I1d0b973f9dac0f1d4f9d4d03faef66f05edde3fc --- .../android/server/ConnectivityServiceInitializer.java | 8 ++------ service-t/src/com/android/server/NsdService.java | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/service-t/src/com/android/server/ConnectivityServiceInitializer.java b/service-t/src/com/android/server/ConnectivityServiceInitializer.java index e4efa9261b..626c2eb68d 100644 --- a/service-t/src/com/android/server/ConnectivityServiceInitializer.java +++ b/service-t/src/com/android/server/ConnectivityServiceInitializer.java @@ -123,12 +123,8 @@ public final class ConnectivityServiceInitializer extends SystemService { /** Return NsdService instance or null if current SDK is lower than T */ private NsdService createNsdService(final Context context) { if (!SdkLevel.isAtLeastT()) return null; - try { - return NsdService.create(context); - } catch (InterruptedException e) { - Log.d(TAG, "Unable to get NSD service", e); - return null; - } + + return NsdService.create(context); } /** Return Nearby service instance or null if current SDK is lower than T */ diff --git a/service-t/src/com/android/server/NsdService.java b/service-t/src/com/android/server/NsdService.java index 995f8aeed1..4086e4ec9b 100644 --- a/service-t/src/com/android/server/NsdService.java +++ b/service-t/src/com/android/server/NsdService.java @@ -600,7 +600,7 @@ public class NsdService extends INsdManager.Stub { mMDnsEventCallback = new MDnsEventCallback(mNsdStateMachine); } - public static NsdService create(Context context) throws InterruptedException { + public static NsdService create(Context context) { HandlerThread thread = new HandlerThread(TAG); thread.start(); Handler handler = new Handler(thread.getLooper());