From a82f2594923b09b747f63c3e2b6e67c425f96f20 Mon Sep 17 00:00:00 2001 From: Chenbo Feng Date: Fri, 27 Apr 2018 15:40:55 -0700 Subject: [PATCH] Directly test xt_qtaguid module without libcutls The libcutls library is no longer directly writing to the xt_qtaguid module proc file. Instead, all the qtaguid related helper function is moved to libqtaguid in P release. So the cts should directly call into libqtaguid instead of using libcutils to do that, otherwise it will faill on devices that using new traffic stats tools. Bug: 78788976 Test: atest CtsNativeNetTestCases Change-Id: I1169f598b6e558acf1d7724416b2b70abe2f5878 --- tests/cts/net/native/qtaguid/Android.mk | 4 ++-- tests/cts/net/native/qtaguid/src/NativeQtaguidTest.cpp | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/cts/net/native/qtaguid/Android.mk b/tests/cts/net/native/qtaguid/Android.mk index 6c92b5c392..bf89e5f015 100644 --- a/tests/cts/net/native/qtaguid/Android.mk +++ b/tests/cts/net/native/qtaguid/Android.mk @@ -29,10 +29,10 @@ LOCAL_SRC_FILES := \ LOCAL_SHARED_LIBRARIES := \ libutils \ liblog \ - libcutils \ LOCAL_STATIC_LIBRARIES := \ - libgtest + libgtest \ + libqtaguid \ LOCAL_CTS_TEST_PACKAGE := android.net.native # Tag this module as a cts test artifact diff --git a/tests/cts/net/native/qtaguid/src/NativeQtaguidTest.cpp b/tests/cts/net/native/qtaguid/src/NativeQtaguidTest.cpp index 7f790fb7c7..1892a44ebd 100644 --- a/tests/cts/net/native/qtaguid/src/NativeQtaguidTest.cpp +++ b/tests/cts/net/native/qtaguid/src/NativeQtaguidTest.cpp @@ -23,7 +23,7 @@ #include #include -#include +#include int hasQtaguidKernelSupport() { struct utsname buf; @@ -87,7 +87,7 @@ void checkNoSocketPointerLeaks(int family) { uint64_t sk_addr; uint64_t expect_addr = 0; - EXPECT_EQ(0, qtaguid_tagSocket(sockfd, tag, uid)); + EXPECT_EQ(0, legacy_tagSocket(sockfd, tag, uid)); EXPECT_EQ(0, getCtrlSkInfo(tag, uid, &sk_addr, &ref_cnt)); EXPECT_EQ(expect_addr, sk_addr); close(sockfd); @@ -106,7 +106,7 @@ TEST (NativeQtaguidTest, close_socket_without_untag) { int tag = arc4random(); int ref_cnt; uint64_t dummy_sk; - EXPECT_EQ(0, qtaguid_tagSocket(sockfd, tag, uid)); + EXPECT_EQ(0, legacy_tagSocket(sockfd, tag, uid)); EXPECT_EQ(0, getCtrlSkInfo(tag, uid, &dummy_sk, &ref_cnt)); EXPECT_EQ(2, ref_cnt); close(sockfd); @@ -125,7 +125,7 @@ TEST (NativeQtaguidTest, close_socket_without_untag_ipv6) { int tag = arc4random(); int ref_cnt; uint64_t dummy_sk; - EXPECT_EQ(0, qtaguid_tagSocket(sockfd, tag, uid)); + EXPECT_EQ(0, legacy_tagSocket(sockfd, tag, uid)); EXPECT_EQ(0, getCtrlSkInfo(tag, uid, &dummy_sk, &ref_cnt)); EXPECT_EQ(2, ref_cnt); close(sockfd);