From 791d142a9862f41168434a5d0c8b59628efa2825 Mon Sep 17 00:00:00 2001 From: Treehugger Robot Date: Thu, 11 Jun 2020 01:37:16 +0000 Subject: [PATCH] Fix MultinetworkApiTest fail problem in instant mode CtsNetUtils#storePrivateDnsSetting might require WRITE_SECURE_SETTINGS permission to run. Therefore, move it from setUp to only belong to the required test case. Bug: 158538281 Test: run cts --include-filter "arm64-v8a CtsNetTestCases[instant] android.net.cts.MultinetworkApiTest" Merged-In: I8ecadd134824a4023a3c6e173d52ba088d46b103 Change-Id: Ic8fa1421b1092efdb011a124836d9f466a231f43 (cherry picked from commit 9451fdf5031d2de02ac9011696b56760ea4943a0) --- tests/cts/net/src/android/net/cts/MultinetworkApiTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cts/net/src/android/net/cts/MultinetworkApiTest.java b/tests/cts/net/src/android/net/cts/MultinetworkApiTest.java index 985e313a92..6d3db8912d 100644 --- a/tests/cts/net/src/android/net/cts/MultinetworkApiTest.java +++ b/tests/cts/net/src/android/net/cts/MultinetworkApiTest.java @@ -68,7 +68,6 @@ public class MultinetworkApiTest extends AndroidTestCase { mCM = (ConnectivityManager) getContext().getSystemService(Context.CONNECTIVITY_SERVICE); mCR = getContext().getContentResolver(); mCtsNetUtils = new CtsNetUtils(getContext()); - mCtsNetUtils.storePrivateDnsSetting(); } @Override @@ -223,6 +222,7 @@ public class MultinetworkApiTest extends AndroidTestCase { @AppModeFull(reason = "WRITE_SECURE_SETTINGS permission can't be granted to instant apps") public void testResNApiNXDomainPrivateDns() throws InterruptedException { + mCtsNetUtils.storePrivateDnsSetting(); // Enable private DNS strict mode and set server to dns.google before doing NxDomain test. // b/144521720 try {