LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gn2bp: rename _set_arg_positional_value for readability

Browse Source 
We could argue about just getting rid of it altogether.

Test: none
Change-Id: I1cfe5657d0faeff044b4dcfefb568eb70e6b8813
This commit is contained in:
Patrick Rohr
2022-11-30 12:56:29 -08:00
parent d7de3dd714
commit 77c4f5c602
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/gn2bp/gen_android_bp
View File

@@ -659,8 +659,7 @@ class BaseActionSanitizer():
i = self.target.args.index(arg) i = self.target.args.index(arg)
self.target.args[i + 1] = value self.target.args[i + 1] = value
def _set_arg_positional_value(self, position, value): def _set_arg_at(self, position, value):
assert(position < len(self.target.args))
self.target.args[position] = value self.target.args[position] = value
def _delete_arg(self, arg): def _delete_arg(self, arg):
@@ -684,7 +683,7 @@ class BaseActionSanitizer():
class WriteBuildDateHeaderSanitizer(BaseActionSanitizer): class WriteBuildDateHeaderSanitizer(BaseActionSanitizer):
def get_args(self): def get_args(self):
self._set_arg_positional_value(0, '$(out)') self._set_arg_at(0, '$(out)')
return super().get_args() return super().get_args()
class WriteBuildFlagHeaderSanitizer(BaseActionSanitizer): class WriteBuildFlagHeaderSanitizer(BaseActionSanitizer):