diff --git a/tests/unit/java/com/android/server/ConnectivityServiceTest.java b/tests/unit/java/com/android/server/ConnectivityServiceTest.java index c19ed611fa..8c4c7c9cca 100644 --- a/tests/unit/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/unit/java/com/android/server/ConnectivityServiceTest.java @@ -10359,6 +10359,12 @@ public class ConnectivityServiceTest { mCellNetworkAgent.connect(true); callback.expectAvailableThenValidatedCallbacks(mCellNetworkAgent); callback.assertNoCallback(); + + // Make sure a report is sent and that the caps are suitably redacted. + verify(mConnectivityDiagnosticsCallback, timeout(TIMEOUT_MS)) + .onConnectivityReportAvailable(argThat(report -> + areConnDiagCapsRedacted(report.getNetworkCapabilities()))); + reset(mConnectivityDiagnosticsCallback); } private boolean areConnDiagCapsRedacted(NetworkCapabilities nc) { @@ -10371,17 +10377,6 @@ public class ConnectivityServiceTest { && ti.settingsRedacted; } - @Test - public void testConnectivityDiagnosticsCallbackOnConnectivityReportAvailable() - throws Exception { - setUpConnectivityDiagnosticsCallback(); - - // Verify onConnectivityReport fired - verify(mConnectivityDiagnosticsCallback, timeout(TIMEOUT_MS)) - .onConnectivityReportAvailable(argThat(report -> - areConnDiagCapsRedacted(report.getNetworkCapabilities()))); - } - @Test public void testConnectivityDiagnosticsCallbackOnDataStallSuspected() throws Exception { setUpConnectivityDiagnosticsCallback(); @@ -10399,9 +10394,6 @@ public class ConnectivityServiceTest { public void testConnectivityDiagnosticsCallbackOnConnectivityReported() throws Exception { setUpConnectivityDiagnosticsCallback(); - // reset to ignore callbacks from setup - reset(mConnectivityDiagnosticsCallback); - final Network n = mCellNetworkAgent.getNetwork(); final boolean hasConnectivity = true; mService.reportNetworkConnectivity(n, hasConnectivity); @@ -10433,9 +10425,6 @@ public class ConnectivityServiceTest { throws Exception { setUpConnectivityDiagnosticsCallback(); - // reset to ignore callbacks from setup - reset(mConnectivityDiagnosticsCallback); - // report known Connectivity from a different uid. Verify that network is not re-validated // and this callback is not notified. final Network n = mCellNetworkAgent.getNetwork();