From 79614aee1272cdf9b81c101ee2984751f37e562a Mon Sep 17 00:00:00 2001 From: Hugo Benichi Date: Thu, 25 May 2017 13:42:31 +0900 Subject: [PATCH] @Ignore ConnectivityServiceTest#testRequestBenchmark Ignore the last remaining test in ConnectivityServiceTest with spurious failures. testRequestBenchmark has some intrinsic chances of failure due to the fact it attempts to assert elapsed time durations against a reference target. Bug: 32561414 Test: no functional change Change-Id: Ib25d76581b47997b2ef84df3e6a9fd9224b85d92 --- tests/net/java/com/android/server/ConnectivityServiceTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/net/java/com/android/server/ConnectivityServiceTest.java b/tests/net/java/com/android/server/ConnectivityServiceTest.java index 00b0f980d3..4fdbfe75da 100644 --- a/tests/net/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/net/java/com/android/server/ConnectivityServiceTest.java @@ -97,6 +97,7 @@ import com.android.server.connectivity.NetworkMonitor; import com.android.server.connectivity.NetworkMonitor.CaptivePortalProbeResult; import com.android.server.net.NetworkPinner; +import org.junit.Ignore; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.mockito.Spy; @@ -2409,6 +2410,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { mCm.unregisterNetworkCallback(fgCallback); } + @Ignore // This test has instrinsic chances of spurious failures: ignore for continuous testing. @SmallTest public void testRequestBenchmark() throws Exception { // TODO: turn this unit test into a real benchmarking test.