LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use safe buffer sizes when parsing network stats.

Browse Source 
Change-Id: I1733c1ddc48f9410136aee7af7889fdc7be8cc10
This commit is contained in:
Jeff Sharkey
2013-02-07 15:02:55 -08:00
parent 5fee2c9ee2
commit 805bdac0a0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/jni/android_net_TrafficStats.cpp
View File

@@ -80,7 +80,7 @@ static int parseIfaceStats(const char* iface, struct Stats* stats) {
return -1; return -1;
} }
char buffer[256]; char buffer[384];
char cur_iface[32]; char cur_iface[32];
bool foundTcp = false; bool foundTcp = false;
uint64_t rxBytes, rxPackets, txBytes, txPackets, tcpRxPackets, tcpTxPackets; uint64_t rxBytes, rxPackets, txBytes, txPackets, tcpRxPackets, tcpTxPackets;
@@ -124,12 +124,12 @@ static int parseUidStats(const uint32_t uid, struct Stats* stats) {
return -1; return -1;
} }
char buffer[256]; char buffer[384];
char iface[32]; char iface[32];
uint32_t idx, cur_uid, set; uint32_t idx, cur_uid, set;
uint64_t tag, rxBytes, rxPackets, txBytes, txPackets; uint64_t tag, rxBytes, rxPackets, txBytes, txPackets;
while (fgets(buffer, 256, fp) != NULL) { while (fgets(buffer, sizeof(buffer), fp) != NULL) {
if (sscanf(buffer, "%d %31s 0x%llx %u %u %llu %llu %llu %llu", &idx, if (sscanf(buffer, "%d %31s 0x%llx %u %u %llu %llu %llu %llu", &idx,
iface, &tag, &cur_uid, &set, &rxBytes, &rxPackets, &txBytes, iface, &tag, &cur_uid, &set, &rxBytes, &rxPackets, &txBytes,
&txPackets) == 9) { &txPackets) == 9) {