LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ListeningPortsTest: Make error message more useful.

Browse Source 
- Add UID of listener to error message.
- Convert hex port number to decimal for easier reading by humans.

Change-Id: I0b8edcf14ebd0c039b936055a265f4706558f9fe
This commit is contained in:
Nick Kralevich
2011-10-05 10:43:01 -07:00
parent a18b717579
commit 8670b1c23f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/cts/net/src/android/net/cts/ListeningPortsTest.java
View File

@@ -118,13 +118,18 @@ public class ListeningPortsTest extends TestCase {
String localAddress = fields[1]; String localAddress = fields[1];
String state = fields[3]; String state = fields[3];
String uid = fields[7];
assertTrue(procFilePath + " should have an IP address in the second column", assertTrue(procFilePath + " should have an IP address in the second column",
isAddress(localAddress)); isAddress(localAddress));
String localIp = localAddress.split(":")[0];
int localPort = Integer.parseInt(localAddress.split(":")[1], 16);
if (!isException(localAddress) && isPortListening(state, isTcp)) { if (!isException(localAddress) && isPortListening(state, isTcp)) {
throw new ListeningPortsAssertionError( throw new ListeningPortsAssertionError(
"Found port listening on " + localAddress + " in " + procFilePath); "Found port listening on addr=" + localIp + ", port="
+ localPort + ", UID=" + uid + " in " + procFilePath);
} }
} }
} catch (FileNotFoundException notFound) { } catch (FileNotFoundException notFound) {