diff --git a/service/src/com/android/server/ConnectivityService.java b/service/src/com/android/server/ConnectivityService.java index 66e39bec3c..87fd6d8dea 100755 --- a/service/src/com/android/server/ConnectivityService.java +++ b/service/src/com/android/server/ConnectivityService.java @@ -5263,7 +5263,7 @@ public class ConnectivityService extends IConnectivityManager.Stub private boolean hasCarrierPrivilegeForNetworkCaps(final int callingUid, @NonNull final NetworkCapabilities caps) { if (mCarrierPrivilegeAuthenticator != null) { - return mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + return mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( callingUid, caps); } return false; diff --git a/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java b/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java index 219d0ff83a..fd65ee5b66 100644 --- a/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java +++ b/service/src/com/android/server/connectivity/CarrierPrivilegeAuthenticator.java @@ -213,7 +213,7 @@ public class CarrierPrivilegeAuthenticator { * @param networkCapabilities the network capabilities for which carrier privilege is checked. * @return true if uid provides the relevant carrier config else false. */ - public boolean hasCarrierPrivilegeForNetworkCapabilities(int callingUid, + public boolean isCarrierServiceUidForNetworkCapabilities(int callingUid, @NonNull NetworkCapabilities networkCapabilities) { if (callingUid == Process.INVALID_UID) return false; final int subId; diff --git a/service/src/com/android/server/connectivity/NetworkAgentInfo.java b/service/src/com/android/server/connectivity/NetworkAgentInfo.java index 23556cbdd0..50cad45bbe 100644 --- a/service/src/com/android/server/connectivity/NetworkAgentInfo.java +++ b/service/src/com/android/server/connectivity/NetworkAgentInfo.java @@ -1598,7 +1598,7 @@ public class NetworkAgentInfo implements NetworkRanker.Scoreable { && (nc.hasSingleTransportBesidesTest(TRANSPORT_CELLULAR) || nc.hasSingleTransportBesidesTest(TRANSPORT_WIFI)) && (1 == nc.getAllowedUidsNoCopy().size()) - && (carrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + && (carrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( nc.getAllowedUidsNoCopy().valueAt(0), nc))) { return true; } diff --git a/tests/unit/java/com/android/server/ConnectivityServiceTest.java b/tests/unit/java/com/android/server/ConnectivityServiceTest.java index 20b0801130..d8ac0ae95d 100755 --- a/tests/unit/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/unit/java/com/android/server/ConnectivityServiceTest.java @@ -79,7 +79,6 @@ import static android.net.ConnectivityManager.PROFILE_NETWORK_PREFERENCE_ENTERPR import static android.net.ConnectivityManager.TYPE_ETHERNET; import static android.net.ConnectivityManager.TYPE_MOBILE; import static android.net.ConnectivityManager.TYPE_MOBILE_SUPL; -import static android.net.ConnectivityManager.TYPE_NONE; import static android.net.ConnectivityManager.TYPE_VPN; import static android.net.ConnectivityManager.TYPE_WIFI; import static android.net.ConnectivitySettingsManager.PRIVATE_DNS_MODE_OFF; @@ -17531,7 +17530,7 @@ public class ConnectivityServiceTest { // In this test TEST_PACKAGE_UID will be the UID of the carrier service UID. doReturn(true).when(mCarrierPrivilegeAuthenticator) - .hasCarrierPrivilegeForNetworkCapabilities(eq(TEST_PACKAGE_UID), any()); + .isCarrierServiceUidForNetworkCapabilities(eq(TEST_PACKAGE_UID), any()); // Simulate a restricted telephony network. The telephony factory is entitled to set // the access UID to the service package on any of its restricted networks. diff --git a/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java b/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java index 81136262b9..d3f53eec36 100644 --- a/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java +++ b/tests/unit/java/com/android/server/connectivity/CarrierPrivilegeAuthenticatorTest.java @@ -164,9 +164,9 @@ public class CarrierPrivilegeAuthenticatorTest { .addTransportType(TRANSPORT_CELLULAR) .setNetworkSpecifier(new TelephonyNetworkSpecifier(0)); - assertTrue(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertTrue(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, ncBuilder.build())); - assertFalse(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertFalse(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid + 1, ncBuilder.build())); } @@ -203,9 +203,9 @@ public class CarrierPrivilegeAuthenticatorTest { .addTransportType(TRANSPORT_CELLULAR) .setNetworkSpecifier(specifier) .build(); - assertTrue(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertTrue(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, nc)); - assertFalse(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertFalse(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid + 1, nc)); } @@ -225,9 +225,9 @@ public class CarrierPrivilegeAuthenticatorTest { listener.onCarrierPrivilegesChanged(Collections.emptyList(), new int[] {}); listener.onCarrierServiceChanged(null, applicationInfo.uid); - assertFalse(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertFalse(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, nc)); - assertTrue(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertTrue(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid + 1, nc)); } @@ -238,11 +238,11 @@ public class CarrierPrivilegeAuthenticatorTest { final NetworkCapabilities.Builder ncBuilder = new NetworkCapabilities.Builder(); ncBuilder.addTransportType(TRANSPORT_CELLULAR); - assertFalse(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertFalse(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, ncBuilder.build())); ncBuilder.setNetworkSpecifier(new TelephonyNetworkSpecifier(0)); - assertTrue(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertTrue(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, ncBuilder.build())); // The builder for NetworkCapabilities doesn't allow removing the transport as long as a @@ -251,7 +251,7 @@ public class CarrierPrivilegeAuthenticatorTest { ncBuilder.removeTransportType(TRANSPORT_CELLULAR); ncBuilder.addTransportType(TRANSPORT_WIFI); ncBuilder.setNetworkSpecifier(new TelephonyNetworkSpecifier(0)); - assertFalse(mCarrierPrivilegeAuthenticator.hasCarrierPrivilegeForNetworkCapabilities( + assertFalse(mCarrierPrivilegeAuthenticator.isCarrierServiceUidForNetworkCapabilities( mCarrierConfigPkgUid, ncBuilder.build())); } }