LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "Fix system_server crash while iterating CookieTagMap" am: dd5a31eb2d

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1990333

Change-Id: I04bd616a62ba77219c0ae812d2337e474b1fe2c2
This commit is contained in:
Maciej Żenczykowski
2022-02-19 22:03:23 +00:00
committed by Automerger Merge Worker
parent a78828383b c4cfd83ad4
commit 94b0f2ff81
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
service-t/src/com/android/server/net/NetworkStatsService.java
View File

@@ -1875,7 +1875,13 @@ public class NetworkStatsService extends INetworkStatsService.Stub {
private void deleteKernelTagData(int uid) { private void deleteKernelTagData(int uid) {
try { try {
mCookieTagMap.forEach((key, value) -> { mCookieTagMap.forEach((key, value) -> {
if (value.uid == uid) { // If SkDestroyListener deletes the socket tag while this code is running,
// forEach will either restart iteration from the beginning or return null,
// depending on when the deletion happens.
// If it returns null, continue iteration to delete the data and in fact it would
// just iterate from first key because BpfMap#getNextKey would return first key
// if the current key is not exist.
if (value != null && value.uid == uid) {
try { try {
mCookieTagMap.deleteEntry(key); mCookieTagMap.deleteEntry(key);
} catch (ErrnoException e) { } catch (ErrnoException e) {