LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "ethernet: fix receiving NetworkOffer callbacks on stale object" am: b916ff898b

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2150733

Change-Id: I435577bd8ac42a0adcdbbb76d35d4d00ecf3a3c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Patrick Rohr
2022-07-18 16:07:53 +00:00
committed by Automerger Merge Worker
parent a757505f31 b916ff898b
commit 9baf09483f
2 changed files with 32 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java
View File

@@ -726,4 +726,16 @@ public class EthernetNetworkFactoryTest {
triggerOnProvisioningSuccess();
verifyRestart(initialIpConfig);
}
@Test
public void testOnNetworkNeededOnStaleNetworkOffer() throws Exception {
initEthernetNetworkFactory();
createAndVerifyProvisionedInterface(TEST_IFACE);
mNetFactory.updateInterfaceLinkState(TEST_IFACE, false, null);
verify(mNetworkProvider).unregisterNetworkOffer(mNetworkOfferCallback);
// It is possible that even after a network offer is unregistered, CS still sends it
// onNetworkNeeded() callbacks.
mNetworkOfferCallback.onNetworkNeeded(createDefaultRequest());
verify(mIpClient, never()).startProvisioning(any());
}
}