Merge "Update CS helper for clearing NetworkCapabilities UIDs." am: 28ce6a8970 am: 2ecef3416b

Change-Id: I4560ffd4558288854e2cb493f6e82a95bc45a88d
This commit is contained in:
Cody Kesting
2020-03-31 20:45:25 +00:00
committed by Automerger Merge Worker

View File

@@ -7918,8 +7918,7 @@ public class ConnectivityService extends IConnectivityManager.Stub
@NonNull ConnectivityReportEvent reportEvent, @NonNull PersistableBundle extras) { @NonNull ConnectivityReportEvent reportEvent, @NonNull PersistableBundle extras) {
final NetworkAgentInfo nai = reportEvent.mNai; final NetworkAgentInfo nai = reportEvent.mNai;
final NetworkCapabilities networkCapabilities = final NetworkCapabilities networkCapabilities =
new NetworkCapabilities(nai.networkCapabilities); getNetworkCapabilitiesWithoutUids(nai.networkCapabilities);
clearNetworkCapabilitiesUids(networkCapabilities);
final ConnectivityReport report = final ConnectivityReport report =
new ConnectivityReport( new ConnectivityReport(
reportEvent.mNai.network, reportEvent.mNai.network,
@@ -7943,8 +7942,7 @@ public class ConnectivityService extends IConnectivityManager.Stub
@NonNull NetworkAgentInfo nai, long timestampMillis, int detectionMethod, @NonNull NetworkAgentInfo nai, long timestampMillis, int detectionMethod,
@NonNull PersistableBundle extras) { @NonNull PersistableBundle extras) {
final NetworkCapabilities networkCapabilities = final NetworkCapabilities networkCapabilities =
new NetworkCapabilities(nai.networkCapabilities); getNetworkCapabilitiesWithoutUids(nai.networkCapabilities);
clearNetworkCapabilitiesUids(networkCapabilities);
final DataStallReport report = final DataStallReport report =
new DataStallReport( new DataStallReport(
nai.network, nai.network,
@@ -7977,10 +7975,12 @@ public class ConnectivityService extends IConnectivityManager.Stub
} }
} }
private void clearNetworkCapabilitiesUids(@NonNull NetworkCapabilities nc) { private NetworkCapabilities getNetworkCapabilitiesWithoutUids(@NonNull NetworkCapabilities nc) {
nc.setUids(null); final NetworkCapabilities sanitized = new NetworkCapabilities(nc);
nc.setAdministratorUids(new int[0]); sanitized.setUids(null);
nc.setOwnerUid(Process.INVALID_UID); sanitized.setAdministratorUids(new int[0]);
sanitized.setOwnerUid(Process.INVALID_UID);
return sanitized;
} }
private List<IConnectivityDiagnosticsCallback> getMatchingPermissionedCallbacks( private List<IConnectivityDiagnosticsCallback> getMatchingPermissionedCallbacks(