LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address comments on NetworkStack AIDL v6

Browse Source 
Address issues found during AIDL review:
 - Rename clientAddr to singleClientAddr
 - Do not use a ParcelableBundle for notifyNetworkTested or
   notifyDataStallSuspected; instead use AIDL parcelables for stronger
   backwards compatibility guarantees.

Test: atest NetworkMonitorTest ConnectivityServiceTest
      ConnectivityServiceIntegrationTest, manual
Bug: 153500847
Merged-In: Id9b71784e5f6294d203230e57737979e063ff0f8
Change-Id: Id9b71784e5f6294d203230e57737979e063ff0f8
This commit is contained in:
Remi NGUYEN VAN
2020-04-24 12:19:37 +00:00
parent 9258a08525
commit a530ebb62d
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tethering/src/android/net/dhcp/DhcpServingParamsParcelExt.java
View File

@@ -169,7 +169,7 @@ public class DhcpServingParamsParcelExt extends DhcpServingParamsParcel {
* <p>If not set, the default value is null.
*/
public DhcpServingParamsParcelExt setSingleClientAddr(@Nullable Inet4Address clientAddr) {
this.clientAddr = clientAddr == null ? 0 : inet4AddressToIntHTH(clientAddr);
this.singleClientAddr = clientAddr == null ? 0 : inet4AddressToIntHTH(clientAddr);
return this;
}

2
Tethering/tests/unit/src/android/net/dhcp/DhcpServingParamsParcelExtTest.java
View File

@@ -110,7 +110,7 @@ public class DhcpServingParamsParcelExtTest {
@Test
public void testSetClientAddr() {
mParcel.setSingleClientAddr(TEST_CLIENT_ADDRESS);
assertEquals(TEST_CLIENT_ADDRESS_PARCELED, mParcel.clientAddr);
assertEquals(TEST_CLIENT_ADDRESS_PARCELED, mParcel.singleClientAddr);
}
private static Inet4Address inet4Addr(String addr) {

2
Tethering/tests/unit/src/com/android/networkstack/tethering/TetheringTest.java
View File

@@ -1689,7 +1689,7 @@ public class TetheringTest {
final DhcpServingParamsParcel params = dhcpParamsCaptor.getValue();
assertEquals(serverAddr, intToInet4AddressHTH(params.serverAddr).getHostAddress());
assertEquals(24, params.serverAddrPrefixLength);
assertEquals(clientAddrParceled, params.clientAddr);
assertEquals(clientAddrParceled, params.singleClientAddr);
}
@Test