LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ConnectivityServiceTest: fix testNetworkInfoOfTypeNone

Browse Source 
This patch fixes a couple of flakyness issues with
testNetworkInfoOfTypeNone. It also fixes some typos and naming issues.

Bug: 62918393, 62918393
Test: runtest frameworks-net
Change-Id: I1c56557ab113d3ef57dbc06a6e882634d03c5b09
This commit is contained in:
Hugo Benichi
2017-07-19 10:10:52 +09:00
parent 1d4be0ece6
commit a6fe35a841
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/net/java/com/android/server/ConnectivityServiceTest.java
View File

@@ -881,6 +881,7 @@ public class ConnectivityServiceTest extends AndroidTestCase {
} }
private void verifyNoNetwork() { private void verifyNoNetwork() {
waitForIdle();
// Test getActiveNetworkInfo() // Test getActiveNetworkInfo()
assertNull(mCm.getActiveNetworkInfo()); assertNull(mCm.getActiveNetworkInfo());
// Test getActiveNetwork() // Test getActiveNetwork()
@@ -3277,7 +3278,7 @@ public class ConnectivityServiceTest extends AndroidTestCase {
ConditionVariable broadcastCV = waitForConnectivityBroadcasts(1); ConditionVariable broadcastCV = waitForConnectivityBroadcasts(1);
verifyNoNetwork(); verifyNoNetwork();
MockNetworkAgent lowpanNetwork = new MockNetworkAgent(TRANSPORT_WIFI_AWARE); MockNetworkAgent wifiAware = new MockNetworkAgent(TRANSPORT_WIFI_AWARE);
assertNull(mCm.getActiveNetworkInfo()); assertNull(mCm.getActiveNetworkInfo());
Network[] allNetworks = mCm.getAllNetworks(); Network[] allNetworks = mCm.getAllNetworks();
@@ -3291,19 +3292,19 @@ public class ConnectivityServiceTest extends AndroidTestCase {
final TestNetworkCallback callback = new TestNetworkCallback(); final TestNetworkCallback callback = new TestNetworkCallback();
mCm.registerNetworkCallback(request, callback); mCm.registerNetworkCallback(request, callback);
// Bring up lowpan. // Bring up wifi aware network.
lowpanNetwork.connect(false, false); wifiAware.connect(false, false);
callback.expectAvailableCallbacks(lowpanNetwork); callback.expectAvailableCallbacks(wifiAware);
assertNull(mCm.getActiveNetworkInfo()); assertNull(mCm.getActiveNetworkInfo());
assertNull(mCm.getActiveNetwork()); assertNull(mCm.getActiveNetwork());
// TODO: getAllNetworkInfo is dirty and returns a non-empty array rght from the start // TODO: getAllNetworkInfo is dirty and returns a non-empty array right from the start
// of this test. Fix it and uncomment the assert below. // of this test. Fix it and uncomment the assert below.
//assertEmpty(mCm.getAllNetworkInfo()); //assertEmpty(mCm.getAllNetworkInfo());
// Disconnect lowpan. // Disconnect wifi aware network.
lowpanNetwork.disconnect(); wifiAware.disconnect();
callback.expectCallback(CallbackState.LOST, lowpanNetwork); callback.expectCallbackLike((info) -> info.state == CallbackState.LOST, TIMEOUT_MS);
mCm.unregisterNetworkCallback(callback); mCm.unregisterNetworkCallback(callback);
verifyNoNetwork(); verifyNoNetwork();