LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce connectivity logging

Browse Source 
Change-Id: I5d45b8fbcd01e42df7f2b1cf02fb5b226128abb8
This commit is contained in:
Wink Saville
2011-09-21 11:05:43 -07:00
parent ade8174d53
commit a7d56571c2
2 changed files with 67 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/net/ProxyProperties.java
View File

@@ -137,6 +137,8 @@ public class ProxyProperties implements Parcelable {
if (mExclusionList != null) { if (mExclusionList != null) {
sb.append(" xl=").append(mExclusionList); sb.append(" xl=").append(mExclusionList);
} }
} else {
sb.append("[ProxyProperties.mHost == null]");
} }
return sb.toString(); return sb.toString();
} }

108
services/java/com/android/server/ConnectivityService.java
View File

@@ -97,7 +97,7 @@ import java.util.List;
public class ConnectivityService extends IConnectivityManager.Stub { public class ConnectivityService extends IConnectivityManager.Stub {
private static final boolean DBG = true; private static final boolean DBG = true;
private static final boolean VDBG = true; private static final boolean VDBG = false;
private static final String TAG = "ConnectivityService"; private static final String TAG = "ConnectivityService";
private static final boolean LOGD_RULES = false; private static final boolean LOGD_RULES = false;
@@ -867,7 +867,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
// javadoc from interface // javadoc from interface
public int startUsingNetworkFeature(int networkType, String feature, public int startUsingNetworkFeature(int networkType, String feature,
IBinder binder) { IBinder binder) {
if (DBG) { if (VDBG) {
log("startUsingNetworkFeature for net " + networkType + ": " + feature); log("startUsingNetworkFeature for net " + networkType + ": " + feature);
} }
enforceChangePermission(); enforceChangePermission();
@@ -933,17 +933,19 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (ni.isConnected() == true) { if (ni.isConnected() == true) {
// add the pid-specific dns // add the pid-specific dns
handleDnsConfigurationChange(usedNetworkType); handleDnsConfigurationChange(usedNetworkType);
if (DBG) log("special network already active"); if (VDBG) log("special network already active");
return Phone.APN_ALREADY_ACTIVE; return Phone.APN_ALREADY_ACTIVE;
} }
if (DBG) log("special network already connecting"); if (VDBG) log("special network already connecting");
return Phone.APN_REQUEST_STARTED; return Phone.APN_REQUEST_STARTED;
} }
// check if the radio in play can make another contact // check if the radio in play can make another contact
// assume if cannot for now // assume if cannot for now
if (DBG) log("reconnecting to special network"); if (DBG) {
log("startUsingNetworkFeature reconnecting to " + networkType + ": " + feature);
}
network.reconnect(); network.reconnect();
return Phone.APN_REQUEST_STARTED; return Phone.APN_REQUEST_STARTED;
} else { } else {
@@ -985,7 +987,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
return stopUsingNetworkFeature(u, true); return stopUsingNetworkFeature(u, true);
} else { } else {
// none found! // none found!
if (VDBG) log("ignoring stopUsingNetworkFeature - not a live request"); if (VDBG) log("stopUsingNetworkFeature - not a live request, ignoring");
return 1; return 1;
} }
} }
@@ -999,12 +1001,15 @@ public class ConnectivityService extends IConnectivityManager.Stub {
NetworkStateTracker tracker = null; NetworkStateTracker tracker = null;
boolean callTeardown = false; // used to carry our decision outside of sync block boolean callTeardown = false; // used to carry our decision outside of sync block
if (DBG) { if (VDBG) {
log("stopUsingNetworkFeature for net " + networkType + log("stopUsingNetworkFeature: net " + networkType + ": " + feature);
": " + feature);
} }
if (!ConnectivityManager.isNetworkTypeValid(networkType)) { if (!ConnectivityManager.isNetworkTypeValid(networkType)) {
if (DBG) {
log("stopUsingNetworkFeature: net " + networkType + ": " + feature +
", net is invalid");
}
return -1; return -1;
} }
@@ -1013,7 +1018,10 @@ public class ConnectivityService extends IConnectivityManager.Stub {
synchronized(this) { synchronized(this) {
// check if this process still has an outstanding start request // check if this process still has an outstanding start request
if (!mFeatureUsers.contains(u)) { if (!mFeatureUsers.contains(u)) {
if (DBG) log("ignoring - this process has no outstanding requests"); if (VDBG) {
log("stopUsingNetworkFeature: this process has no outstanding requests" +
", ignoring");
}
return 1; return 1;
} }
u.unlinkDeathRecipient(); u.unlinkDeathRecipient();
@@ -1028,7 +1036,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (ignoreDups == false) { if (ignoreDups == false) {
for (FeatureUser x : mFeatureUsers) { for (FeatureUser x : mFeatureUsers) {
if (x.isSameUser(u)) { if (x.isSameUser(u)) {
if (DBG) log("ignoring stopUsingNetworkFeature as dup is found"); if (VDBG) log("stopUsingNetworkFeature: dup is found, ignoring");
return 1; return 1;
} }
} }
@@ -1039,7 +1047,10 @@ public class ConnectivityService extends IConnectivityManager.Stub {
tracker = mNetTrackers[usedNetworkType]; tracker = mNetTrackers[usedNetworkType];
if (tracker == null) { if (tracker == null) {
if (DBG) log("ignoring - no known tracker for net type " + usedNetworkType); if (DBG) {
log("stopUsingNetworkFeature: net " + networkType + ": " + feature +
" no known tracker for used net type " + usedNetworkType);
}
return -1; return -1;
} }
if (usedNetworkType != networkType) { if (usedNetworkType != networkType) {
@@ -1047,17 +1058,25 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mNetRequestersPids[usedNetworkType].remove(currentPid); mNetRequestersPids[usedNetworkType].remove(currentPid);
reassessPidDns(pid, true); reassessPidDns(pid, true);
if (mNetRequestersPids[usedNetworkType].size() != 0) { if (mNetRequestersPids[usedNetworkType].size() != 0) {
if (DBG) log("not tearing down special network - " + if (VDBG) {
"others still using it"); log("stopUsingNetworkFeature: net " + networkType + ": " + feature +
" others still using it");
}
return 1; return 1;
} }
callTeardown = true; callTeardown = true;
} else { } else {
if (DBG) log("not a known feature - dropping"); if (DBG) {
log("stopUsingNetworkFeature: net " + networkType + ": " + feature +
" not a known feature - dropping");
}
} }
} }
if (DBG) log("Doing network teardown");
if (callTeardown) { if (callTeardown) {
if (DBG) {
log("stopUsingNetworkFeature: teardown net " + networkType + ": " + feature);
}
tracker.teardown(); tracker.teardown();
return 1; return 1;
} else { } else {
@@ -1592,7 +1611,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mInitialBroadcast = new Intent(intent); mInitialBroadcast = new Intent(intent);
} }
intent.addFlags(Intent.FLAG_RECEIVER_REGISTERED_ONLY_BEFORE_BOOT); intent.addFlags(Intent.FLAG_RECEIVER_REGISTERED_ONLY_BEFORE_BOOT);
if (DBG) { if (VDBG) {
log("sendStickyBroadcast: action=" + intent.getAction()); log("sendStickyBroadcast: action=" + intent.getAction());
} }
@@ -1604,7 +1623,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (delayMs <= 0) { if (delayMs <= 0) {
sendStickyBroadcast(intent); sendStickyBroadcast(intent);
} else { } else {
if (DBG) { if (VDBG) {
log("sendStickyBroadcastDelayed: delayMs=" + delayMs + ", action=" log("sendStickyBroadcastDelayed: delayMs=" + delayMs + ", action="
+ intent.getAction()); + intent.getAction());
} }
@@ -1779,12 +1798,12 @@ public class ConnectivityService extends IConnectivityManager.Stub {
} }
} }
if (resetDns) { if (resetDns) {
if (DBG) log("resetting DNS cache for " + iface); if (VDBG) log("resetting DNS cache for " + iface);
try { try {
mNetd.flushInterfaceDnsCache(iface); mNetd.flushInterfaceDnsCache(iface);
} catch (Exception e) { } catch (Exception e) {
// never crash - catch them all // never crash - catch them all
loge("Exception resetting dns cache: " + e); if (DBG) loge("Exception resetting dns cache: " + e);
} }
} }
} }
@@ -1840,12 +1859,12 @@ public class ConnectivityService extends IConnectivityManager.Stub {
// remove the default route unless somebody else has asked for it // remove the default route unless somebody else has asked for it
String ifaceName = newLp.getInterfaceName(); String ifaceName = newLp.getInterfaceName();
if (TextUtils.isEmpty(ifaceName) == false && mAddedRoutes.contains(r) == false) { if (TextUtils.isEmpty(ifaceName) == false && mAddedRoutes.contains(r) == false) {
if (DBG) log("Removing " + r + " for interface " + ifaceName); if (VDBG) log("Removing " + r + " for interface " + ifaceName);
try { try {
mNetd.removeRoute(ifaceName, r); mNetd.removeRoute(ifaceName, r);
} catch (Exception e) { } catch (Exception e) {
// never crash - catch them all // never crash - catch them all
loge("Exception trying to remove a route: " + e); if (VDBG) loge("Exception trying to remove a route: " + e);
} }
} }
} }
@@ -2059,7 +2078,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mNetd.setDnsServersForInterface(iface, NetworkUtils.makeStrings(dnses)); mNetd.setDnsServersForInterface(iface, NetworkUtils.makeStrings(dnses));
mNetd.setDefaultInterfaceForDns(iface); mNetd.setDefaultInterfaceForDns(iface);
} catch (Exception e) { } catch (Exception e) {
loge("exception setting default dns interface: " + e); if (VDBG) loge("exception setting default dns interface: " + e);
} }
} }
if (!domains.equals(SystemProperties.get("net.dns.search"))) { if (!domains.equals(SystemProperties.get("net.dns.search"))) {
@@ -2089,7 +2108,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mNetd.setDnsServersForInterface(p.getInterfaceName(), mNetd.setDnsServersForInterface(p.getInterfaceName(),
NetworkUtils.makeStrings(dnses)); NetworkUtils.makeStrings(dnses));
} catch (Exception e) { } catch (Exception e) {
loge("exception setting dns servers: " + e); if (VDBG) loge("exception setting dns servers: " + e);
} }
// set per-pid dns for attached secondary nets // set per-pid dns for attached secondary nets
List pids = mNetRequestersPids[netType]; List pids = mNetRequestersPids[netType];
@@ -2194,9 +2213,12 @@ public class ConnectivityService extends IConnectivityManager.Stub {
int type = info.getType(); int type = info.getType();
NetworkInfo.State state = info.getState(); NetworkInfo.State state = info.getState();
if (DBG) log("ConnectivityChange for " + if (VDBG || (state == NetworkInfo.State.CONNECTED) ||
(state == NetworkInfo.State.DISCONNECTED)) {
log("ConnectivityChange for " +
info.getTypeName() + ": " + info.getTypeName() + ": " +
state + "/" + info.getDetailedState()); state + "/" + info.getDetailedState());
}
// Connectivity state changed: // Connectivity state changed:
// [31-13] Reserved for future use // [31-13] Reserved for future use
@@ -2458,23 +2480,24 @@ public class ConnectivityService extends IConnectivityManager.Stub {
} }
private void handleInetConditionChange(int netType, int condition) { private void handleInetConditionChange(int netType, int condition) {
if (DBG) {
log("Inet connectivity change, net=" +
netType + ", condition=" + condition +
",mActiveDefaultNetwork=" + mActiveDefaultNetwork);
}
if (mActiveDefaultNetwork == -1) { if (mActiveDefaultNetwork == -1) {
if (DBG) log("no active default network - aborting"); if (DBG) log("handleInetConditionChange: no active default network - ignore");
return; return;
} }
if (mActiveDefaultNetwork != netType) { if (mActiveDefaultNetwork != netType) {
if (DBG) log("given net not default - aborting"); if (DBG) log("handleInetConditionChange: net=" + netType +
" != default=" + mActiveDefaultNetwork + " - ignore");
return; return;
} }
if (VDBG) {
log("handleInetConditionChange: net=" +
netType + ", condition=" + condition +
",mActiveDefaultNetwork=" + mActiveDefaultNetwork);
}
mDefaultInetCondition = condition; mDefaultInetCondition = condition;
int delay; int delay;
if (mInetConditionChangeInFlight == false) { if (mInetConditionChangeInFlight == false) {
if (VDBG) log("starting a change hold"); if (VDBG) log("handleInetConditionChange: starting a change hold");
// setup a new hold to debounce this // setup a new hold to debounce this
if (mDefaultInetCondition > 50) { if (mDefaultInetCondition > 50) {
delay = Settings.Secure.getInt(mContext.getContentResolver(), delay = Settings.Secure.getInt(mContext.getContentResolver(),
@@ -2487,26 +2510,25 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mHandler.sendMessageDelayed(mHandler.obtainMessage(EVENT_INET_CONDITION_HOLD_END, mHandler.sendMessageDelayed(mHandler.obtainMessage(EVENT_INET_CONDITION_HOLD_END,
mActiveDefaultNetwork, mDefaultConnectionSequence), delay); mActiveDefaultNetwork, mDefaultConnectionSequence), delay);
} else { } else {
// we've set the new condition, when this hold ends that will get // we've set the new condition, when this hold ends that will get picked up
// picked up if (VDBG) log("handleInetConditionChange: currently in hold - not setting new end evt");
if (VDBG) log("currently in hold - not setting new end evt");
} }
} }
private void handleInetConditionHoldEnd(int netType, int sequence) { private void handleInetConditionHoldEnd(int netType, int sequence) {
if (VDBG) { if (DBG) {
log("Inet hold end, net=" + netType + log("handleInetConditionHoldEnd: net=" + netType +
", condition =" + mDefaultInetCondition + ", condition=" + mDefaultInetCondition +
", published condition =" + mDefaultInetConditionPublished); ", published condition=" + mDefaultInetConditionPublished);
} }
mInetConditionChangeInFlight = false; mInetConditionChangeInFlight = false;
if (mActiveDefaultNetwork == -1) { if (mActiveDefaultNetwork == -1) {
if (DBG) log("no active default network - aborting"); if (DBG) log("handleInetConditionHoldEnd: no active default network - ignoring");
return; return;
} }
if (mDefaultConnectionSequence != sequence) { if (mDefaultConnectionSequence != sequence) {
if (DBG) log("event hold for obsolete network - aborting"); if (DBG) log("handleInetConditionHoldEnd: event hold for obsolete network - ignoring");
return; return;
} }
// TODO: Figure out why this optimization sometimes causes a // TODO: Figure out why this optimization sometimes causes a
@@ -2518,7 +2540,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
//} //}
NetworkInfo networkInfo = mNetTrackers[mActiveDefaultNetwork].getNetworkInfo(); NetworkInfo networkInfo = mNetTrackers[mActiveDefaultNetwork].getNetworkInfo();
if (networkInfo.isConnected() == false) { if (networkInfo.isConnected() == false) {
if (DBG) log("default network not connected - aborting"); if (DBG) log("handleInetConditionHoldEnd: default network not connected - ignoring");
return; return;
} }
mDefaultInetConditionPublished = mDefaultInetCondition; mDefaultInetConditionPublished = mDefaultInetCondition;