diff --git a/service/Android.bp b/service/Android.bp index 7dcc8885a1..70affd3adc 100644 --- a/service/Android.bp +++ b/service/Android.bp @@ -143,8 +143,6 @@ java_library { "src/**/*.java", ":framework-connectivity-shared-srcs", ":services-connectivity-shared-srcs", - // TODO: move to net-utils-device-common - ":connectivity-module-utils-srcs", ], libs: [ "framework-annotations-lib", diff --git a/service/src/com/android/server/ConnectivityService.java b/service/src/com/android/server/ConnectivityService.java index 45c4889f4a..1ac95a16a4 100644 --- a/service/src/com/android/server/ConnectivityService.java +++ b/service/src/com/android/server/ConnectivityService.java @@ -89,7 +89,6 @@ import static android.net.NetworkRequest.Type.LISTEN_FOR_BEST; import static android.net.NetworkScore.POLICY_TRANSPORT_PRIMARY; import static android.net.OemNetworkPreferences.OEM_NETWORK_PREFERENCE_TEST; import static android.net.OemNetworkPreferences.OEM_NETWORK_PREFERENCE_TEST_ONLY; -import static android.net.shared.NetworkMonitorUtils.isPrivateDnsValidationRequired; import static android.os.Process.INVALID_UID; import static android.os.Process.VPN_UID; import static android.provider.DeviceConfig.NAMESPACE_CONNECTIVITY; @@ -98,6 +97,7 @@ import static android.system.OsConstants.IPPROTO_TCP; import static android.system.OsConstants.IPPROTO_UDP; import static com.android.net.module.util.DeviceConfigUtils.TETHERING_MODULE_NAME; +import static com.android.net.module.util.NetworkMonitorUtils.isPrivateDnsValidationRequired; import static com.android.net.module.util.PermissionUtils.enforceAnyPermissionOf; import static com.android.net.module.util.PermissionUtils.enforceNetworkStackPermission; import static com.android.net.module.util.PermissionUtils.enforceNetworkStackPermissionOr; diff --git a/tests/unit/java/com/android/server/ConnectivityServiceTest.java b/tests/unit/java/com/android/server/ConnectivityServiceTest.java index fcba78b9a7..4b832ddf9d 100644 --- a/tests/unit/java/com/android/server/ConnectivityServiceTest.java +++ b/tests/unit/java/com/android/server/ConnectivityServiceTest.java @@ -302,7 +302,6 @@ import android.net.netd.aidl.NativeUidRangeConfig; import android.net.networkstack.NetworkStackClientBase; import android.net.resolv.aidl.Nat64PrefixEventParcel; import android.net.resolv.aidl.PrivateDnsValidationEventParcel; -import android.net.shared.NetworkMonitorUtils; import android.net.shared.PrivateDnsConfig; import android.net.util.MultinetworkPolicyTracker; import android.net.wifi.WifiInfo; @@ -358,6 +357,7 @@ import com.android.modules.utils.build.SdkLevel; import com.android.net.module.util.ArrayTrackRecord; import com.android.net.module.util.CollectionUtils; import com.android.net.module.util.LocationPermissionChecker; +import com.android.net.module.util.NetworkMonitorUtils; import com.android.networkstack.apishim.NetworkAgentConfigShimImpl; import com.android.networkstack.apishim.api29.ConstantsShim; import com.android.server.ConnectivityService.ConnectivityDiagnosticsCallbackInfo; @@ -2993,8 +2993,7 @@ public class ConnectivityServiceTest { @Test public void testRequiresValidation() { - assertTrue(NetworkMonitorUtils.isValidationRequired( - NetworkAgentConfigShimImpl.newInstance(null), + assertTrue(NetworkMonitorUtils.isValidationRequired(false /* isVpnValidationRequired */, mCm.getDefaultRequest().networkCapabilities)); } @@ -7984,7 +7983,8 @@ public class ConnectivityServiceTest { // VPN networks do not satisfy the default request and are automatically validated // by NetworkMonitor assertFalse(NetworkMonitorUtils.isValidationRequired( - NetworkAgentConfigShimImpl.newInstance(mMockVpn.getNetworkAgentConfig()), + NetworkAgentConfigShimImpl.newInstance(mMockVpn.getNetworkAgentConfig()) + .isVpnValidationRequired(), mMockVpn.getAgent().getNetworkCapabilities())); mMockVpn.getAgent().setNetworkValid(false /* isStrictMode */); @@ -8135,7 +8135,8 @@ public class ConnectivityServiceTest { assertTrue(nc.hasCapability(NET_CAPABILITY_INTERNET)); assertFalse(NetworkMonitorUtils.isValidationRequired( - NetworkAgentConfigShimImpl.newInstance(mMockVpn.getNetworkAgentConfig()), + NetworkAgentConfigShimImpl.newInstance(mMockVpn.getNetworkAgentConfig()) + .isVpnValidationRequired(), mMockVpn.getAgent().getNetworkCapabilities())); assertTrue(NetworkMonitorUtils.isPrivateDnsValidationRequired( mMockVpn.getAgent().getNetworkCapabilities()));