From 92a0487493dbbb030ad4d7050da7aaaebb1fcf05 Mon Sep 17 00:00:00 2001 From: Ian Rogers Date: Wed, 18 May 2016 19:58:56 -0700 Subject: [PATCH] Fix 2 instances of buggy double check locking on non-volatile fields. Bug caught by Error Prone: http://errorprone.info/bugpattern/DoubleCheckedLocking Bug: 27723540 Change-Id: I0b0c06ce4ae1ffb668e8ab3a7fe07706df173f18 --- .../core/java/com/android/server/net/NetworkStatsObservers.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/net/NetworkStatsObservers.java b/services/core/java/com/android/server/net/NetworkStatsObservers.java index 6f781b3ebb..77292846be 100644 --- a/services/core/java/com/android/server/net/NetworkStatsObservers.java +++ b/services/core/java/com/android/server/net/NetworkStatsObservers.java @@ -68,7 +68,7 @@ class NetworkStatsObservers { private final AtomicInteger mNextDataUsageRequestId = new AtomicInteger(); // Lazily instantiated when an observer is registered. - private Handler mHandler; + private volatile Handler mHandler; /** * Creates a wrapper that contains the caller context and a normalized request.