From b375738a52cb316e8ed283ece6aa8f877fe6b2f2 Mon Sep 17 00:00:00 2001 From: paulhu Date: Thu, 4 Apr 2019 00:57:26 -0700 Subject: [PATCH] Fix ConnectivityServiceTest fail. NetdService#getInstance() will get null object in WrappedConnectivityService constructor. Then pass this null INetd object to PermissionMonitor will case NPE in PermissionMonitor#sendPackagePermissionsToNetd() Bug: 128024100 Test: atest FrameworksNetTests Change-Id: Ia1c80f9600a19c4aaf3f3c1b497b355d96c49c8e Merged-In: I7f185e731db91c30a9b0f14aefbdbb067942190e Merged-In: Ic77ef73841266da487401ffd657ef63562b6fc1e (cherry picked from commit 7d215078521ea03bbd692364e882d02ad065ced0) --- .../com/android/server/connectivity/PermissionMonitor.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/connectivity/PermissionMonitor.java b/services/core/java/com/android/server/connectivity/PermissionMonitor.java index da1360d595..b6946023e8 100644 --- a/services/core/java/com/android/server/connectivity/PermissionMonitor.java +++ b/services/core/java/com/android/server/connectivity/PermissionMonitor.java @@ -469,7 +469,10 @@ public class PermissionMonitor { */ @VisibleForTesting void sendPackagePermissionsToNetd(SparseIntArray netdPermissionsAppIds) { - + if (mNetd == null) { + Log.e(TAG, "Failed to get the netd service"); + return; + } ArrayList allPermissionAppIds = new ArrayList<>(); ArrayList internetPermissionAppIds = new ArrayList<>(); ArrayList updateStatsPermissionAppIds = new ArrayList<>();