LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "Simplify unregister logic for Connectivity Diagnostics callbacks."

Browse Source
This commit is contained in:
Cody Kesting
2020-03-31 20:18:01 +00:00
committed by Gerrit Code Review
parent 87ce14f328 2b1a61cf4b
commit bf4f1d9e98
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
services/core/java/com/android/server/ConnectivityService.java
View File

@@ -7883,12 +7883,14 @@ public class ConnectivityService extends IConnectivityManager.Stub
ensureRunningOnConnectivityServiceThread(); ensureRunningOnConnectivityServiceThread();
final IBinder iCb = cb.asBinder(); final IBinder iCb = cb.asBinder();
if (!mConnectivityDiagnosticsCallbacks.containsKey(iCb)) { final ConnectivityDiagnosticsCallbackInfo cbInfo =
mConnectivityDiagnosticsCallbacks.remove(iCb);
if (cbInfo == null) {
if (VDBG) log("Removing diagnostics callback that is not currently registered"); if (VDBG) log("Removing diagnostics callback that is not currently registered");
return; return;
} }
final NetworkRequestInfo nri = mConnectivityDiagnosticsCallbacks.get(iCb).mRequestInfo; final NetworkRequestInfo nri = cbInfo.mRequestInfo;
if (uid != nri.mUid) { if (uid != nri.mUid) {
if (VDBG) loge("Different uid than registrant attempting to unregister cb"); if (VDBG) loge("Different uid than registrant attempting to unregister cb");
@@ -7900,8 +7902,6 @@ public class ConnectivityService extends IConnectivityManager.Stub
// enforceRequestCountLimit(). // enforceRequestCountLimit().
decrementNetworkRequestPerUidCount(nri); decrementNetworkRequestPerUidCount(nri);
final ConnectivityDiagnosticsCallbackInfo cbInfo =
mConnectivityDiagnosticsCallbacks.remove(iCb);
iCb.unlinkToDeath(cbInfo, 0); iCb.unlinkToDeath(cbInfo, 0);
} }