LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "Add test coverage for ConnectivityService.dump with arguments"

Browse Source
This commit is contained in:
Chiachang Wang
2022-06-01 05:41:50 +00:00
committed by Gerrit Code Review
parent 5eaefa21bf 9673c4ddad
commit c0b2b37faa
1 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/unit/java/com/android/server/ConnectivityServiceTest.java
View File

@@ -11704,6 +11704,12 @@ public class ConnectivityServiceTest {
mCm.unregisterNetworkCallback(networkCallback);
}
private void verifyDump(String[] args) {
final StringWriter stringWriter = new StringWriter();
mService.dump(new FileDescriptor(), new PrintWriter(stringWriter), args);
assertFalse(stringWriter.toString().isEmpty());
}
@Test
public void testDumpDoesNotCrash() {
mServiceContext.setPermission(DUMP, PERMISSION_GRANTED);
@@ -11716,11 +11722,26 @@ public class ConnectivityServiceTest {
.addTransportType(TRANSPORT_WIFI).build();
mCm.registerNetworkCallback(genericRequest, genericNetworkCallback);
mCm.registerNetworkCallback(wifiRequest, wifiNetworkCallback);
final StringWriter stringWriter = new StringWriter();
mService.dump(new FileDescriptor(), new PrintWriter(stringWriter), new String[0]);
verifyDump(new String[0]);
assertFalse(stringWriter.toString().isEmpty());
// Verify dump with arguments.
final String dumpPrio = "--dump-priority";
final String[] dumpArgs = {dumpPrio};
verifyDump(dumpArgs);
final String[] highDumpArgs = {dumpPrio, "HIGH"};
verifyDump(highDumpArgs);
final String[] normalDumpArgs = {dumpPrio, "NORMAL"};
verifyDump(normalDumpArgs);
// Invalid args should do dumpNormal w/o exception
final String[] unknownDumpArgs = {dumpPrio, "UNKNOWN"};
verifyDump(unknownDumpArgs);
final String[] invalidDumpArgs = {"UNKNOWN"};
verifyDump(invalidDumpArgs);
}
@Test